github-vscode-icons: vscode icons for files are no longer loaded in latest chrome

On latest Chrome, folder icons are applied, however, file icons look like this.

image

This behavior also valid for GitLab too. Folders are visible, file icons are not.

I catch this error in console:

content.js:1 Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined
    at content.js:1
    at y (content.js:1)
    at Object.t.initGithub [as github] (content.js:1)
    at Object.t.showIconsForHosting (content.js:1)
    at content.js:1
    at Generator.next (<anonymous>)
    at p (content.js:1)
(anonymous) @ content.js:1
y @ content.js:1
t.initGithub @ content.js:1
t.showIconsForHosting @ content.js:1
(anonymous) @ content.js:1
p @ content.js:1
Promise.then (async)
g @ content.js:1
(anonymous) @ content.js:1
l @ content.js:1
(anonymous) @ content.js:1
(anonymous) @ content.js:1
s @ content.js:1
(anonymous) @ content.js:1
(anonymous) @ content.js:1

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Reactions: 1
  • Comments: 27 (10 by maintainers)

Most upvoted comments

Thanks, closing closed Issue, for now ๐Ÿ˜„

@steebchen should be available for you in next few hours ๐Ÿ˜ƒ

Ok, thank you very much for details. It looks like refined github is manipulating with DOM and that causes errors.

Will try fix it ASAP ๐Ÿ˜ƒ

In my case, I think itโ€™s because of the extension refined github. When I disable this extension everything works. However, this was just happening for some days/weeks (was on vacation so Iโ€™m not sure) โ€“ I was using refined github with vscode icons before and everything worked fine until recently.

Guys, Thank you very much for your support and patience. Finally, I was able to reproduce error (I can only reproduce it in chromium, not in chrome). It seems refined-github changed placement of github svg icon again.

I published new version 1.19 to chrome store, so you can to expect working version in next few hours. I also added better error messaging (in console) and catching (unknown icons donโ€™t break whole repo).

Confirmed. Works now on Vivaldi

Confirmed. Works here on Chrome.

Thanks!

My version is 19.5.19.1547. I enabled private access token (also tried without it).

I see error at top:

Refused to load the font 'data:application/font-woff2;base64,d09GMgABAAAAAQ5sABIAAAADuOQAAQ4EAAEAgwAAAAAAAAAAAAAAAAAAAAAAAAAAG4SpIhy4XhSHMgZgAJJmCF4JgnMREAqGskiFyggSgrVoATYCJAOdOAuOXgAEIAWPGAfGYAyDGFsKfLME/nOMvX+HnQoMqyRqK6tt2TW8K2BDX9Umu4PZkCXwtMjpcHYNTx6UUmu30UdwcxxnVMvcNgAim7rdXiPZ////////////C5dF2ObuXM7ZvQeSECARwueHlaLVtkJEIaLRAI3ulswSE13cSPdM15RCyYQuuS7A0mBqpQO9pYZWQQMqa9lQb0dpJzHxHpLyCHIi8uBdwF58nNH+YOA40OpJvEjJtaokKaUkx/N5UeSinp5TWoW1vSpFjimBgeFGeCF66U0n6ZUN/qSqC4XC11GKUNmzSy2d5Jxyqw5JzGUlJUnyi0lKkE8BlxadTZsyRm8c1/Cti2hEjzIH...FVw9csGnQ1BnbMbfzgRj3WjPytwZYWpPh3OtmsLZaNcxxqaGVqMVqFffFpU8bbs/0N1vG3POWfS7LUeB81TfHn+VbD7x/UnT3lXyFltHfdX6+X6Rzmg9d4dAISK7GlTj2zgME/JUwAETAECwABAUgUmAysrKI5shRwAchnFSMheQ8UoKlvnVbkW9mMeq2+bbO9EQ2q09Z9wzsADarYt4ftoamBDi8gmfbZKnl+lkZWyRx1VYVSIpVFXs9VXy9ytCyTNYt09YIAGKjqpDT22SgOdP5OsdAK/vOCXFnrpEwA/PPTJiopB7HxZV+MlaGCT/04K/LY3kjPYV/YR146Ggg+9sX6na/c2So+Epz3PXve3PKRylPIhNZASBUYVDIGhikiWc1jj/claeVCJvljX7JfvO+xhfTDIjSXBs4HV16Ol/BMfcuFQ4NRmDOWEh6diOI6NZmGl87N9J+r2JfpW2+5NhV/fGHLO57Yavbq7zaCewa/RDxp/aSH+luOPwAA' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

...
enabled features list of refined github
...

Denying load of <URL>. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.
github-vscode-icons:1 Denying load of chrome-extension://hoccpcefjcgnabbmojbfoflggkecmpgd/icons/. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.

GET chrome-extension://invalid/ net::ERR_FAILED
Image (async)
(anonymous) @ content.js:1
g @ content.js:1
(anonymous) @ content.js:1
requestAnimationFrame (async)
o @ content.js:1
mutate @ content.js:1
(anonymous) @ content.js:1
y @ content.js:1
t.initGithub @ content.js:1
t.showIconsForHosting @ content.js:1
(anonymous) @ content.js:1
p @ content.js:1
Promise.then (async)
g @ content.js:1
(anonymous) @ content.js:1
l @ content.js:1
(anonymous) @ content.js:1
(anonymous) @ content.js:1
s @ content.js:1
(anonymous) @ content.js:1
(anonymous) @ content.js:1


Chrome Version 74.0.3729.157 (Official Build) (64-bit)

Itโ€™s published for a few days now by the way, thanks for fixing!

@steebchen thanks for mentioning firefox, I totally forgot about itโ€ฆ

I submited new version in firefox dev, but it will take much more time (to be reviewed from firefox side) than in chrome store before it will be available for you ๐Ÿ˜•

Thanks! Fixed on my end.

Same issue on latest Firefox on Linux:

Sometimes, the folder icons are showing: Selection_999(1219)

Most times, no icons are loading at all though: Selection_999(1220)