github-vscode-icons: vscode icons for files are no longer loaded in latest chrome
On latest Chrome, folder icons are applied, however, file icons look like this.
This behavior also valid for GitLab too. Folders are visible, file icons are not.
I catch this error in console:
content.js:1 Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined
at content.js:1
at y (content.js:1)
at Object.t.initGithub [as github] (content.js:1)
at Object.t.showIconsForHosting (content.js:1)
at content.js:1
at Generator.next (<anonymous>)
at p (content.js:1)
(anonymous) @ content.js:1
y @ content.js:1
t.initGithub @ content.js:1
t.showIconsForHosting @ content.js:1
(anonymous) @ content.js:1
p @ content.js:1
Promise.then (async)
g @ content.js:1
(anonymous) @ content.js:1
l @ content.js:1
(anonymous) @ content.js:1
(anonymous) @ content.js:1
s @ content.js:1
(anonymous) @ content.js:1
(anonymous) @ content.js:1
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 1
- Comments: 27 (10 by maintainers)
Thanks, closing closed Issue, for now ๐
@steebchen should be available for you in next few hours ๐
Ok, thank you very much for details. It looks like refined github is manipulating with DOM and that causes errors.
Will try fix it ASAP ๐
In my case, I think itโs because of the extension refined github. When I disable this extension everything works. However, this was just happening for some days/weeks (was on vacation so Iโm not sure) โ I was using refined github with vscode icons before and everything worked fine until recently.
Guys, Thank you very much for your support and patience. Finally, I was able to reproduce error (I can only reproduce it in chromium, not in chrome). It seems refined-github changed placement of github svg icon again.
I published new version
1.19
to chrome store, so you can to expect working version in next few hours. I also added better error messaging (in console) and catching (unknown icons donโt break whole repo).Confirmed. Works now on Vivaldi
Confirmed. Works here on Chrome.
Thanks!
My version is
19.5.19.1547
. I enabled private access token (also tried without it).I see error at top:
Chrome Version 74.0.3729.157 (Official Build) (64-bit)
Itโs published for a few days now by the way, thanks for fixing!
@steebchen thanks for mentioning firefox, I totally forgot about itโฆ
I submited new version in firefox dev, but it will take much more time (to be reviewed from firefox side) than in chrome store before it will be available for you ๐
Thanks! Fixed on my end.
Same issue on latest Firefox on Linux:
Sometimes, the folder icons are showing:
Most times, no icons are loading at all though: