helm-diff: `.Release.Revision` not working correctly in diff

Hi, we have a pod label as follows that includes the helm revision number as a value:

tags.datadoghq.com/version: {{ .Release.Revision | default 0 | quote }}

This seems to work fine with helm, but with helm diff, the value is always displayed as “1” in the diff:

Observed output in diff:

-     tags.datadoghq.com/version: "5"
+     tags.datadoghq.com/version: "1"

Expected output in diff:

-     tags.datadoghq.com/version: "5"
+     tags.datadoghq.com/version: "6"

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Reactions: 6
  • Comments: 15

Commits related to this issue

Most upvoted comments

Ok, so apparently helm template works as intended. One way to fix this could be replacing the command used to render templates, so we use upgrade --dry-run instead of template

@strainovic Thanks! Gotcha. I was rather in an impression that that kind of inactivity means maturity of the project 😃

I use helm-diff and helmfile and haven’t seen big blockers for a year or so.

I occasionally review issues and pull requests but most of the time (1) they look like not necessities but nice-to-haves, good workarounds exist, or (2)no preceding issues are written to clarify the goals of the changes so I’m unsure if I should merge it or (3)have no tests or manual test report so I’m not sure if I can safely merge it or (4) I responded/asked question(s) but no one answers, or (5)many people talk about big dreams but no one actually contributes code 😢

Regarding this issue, I already took some time to test helm upgrade --dry-run myself, wrote my thought and concern in https://github.com/databus23/helm-diff/issues/253#issuecomment-842733991, and I’m now awaiting replies and feedbacks.

And I thought it’s reasonable and forgivable to wait a few weeks until anyone tries to contribute, as this is annoying but not critical as you can just omit .Release.Revision from the chart template… I actually don’t understand why one wants to have it in k8s resource labels.

a lot of things have been changed since then.

If you’ve specific/critical things helm-diff needs to address, please feel free to raise issues.

I can’t promise to do everyone’s all works myself, but I’ll try keeping my best to maintain the project!

As far as I can see, helm-diff is not maintained actively?

@strainovic Hey! What is the point to calling it not maintained actively? Are you willing to contribute?