shallowequal: Breaking webpack production builds

Uglify does not support let statements. Due to the recent release many webpack production builds are failing because of this.

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 16 (4 by maintainers)

Most upvoted comments

I released v1.0.1 with var switched out in favour of let and const.

Hopefully this shouldn’t break webpack builds.

I just published 1.1.2 of react-side-effect rolling back the shallowequal dependency to resolve the broken builds.

No good deed goes unpunished, right? 😅 Thanks for prompt reply @dashed

Ugh. I knew something would break when I refreshed the project. 😞

I’ll use var in favour of let and const; and push the update out asap.

Indeed, I am running into this issue as well. I can confirm that replacing let with var fixes the build (I can’t speak to the correctness, as I’ve not tested it).

Right! I also get an error in the build.

ERROR in main-df07a8a05e193c746606.js from UglifyJs
Unexpected token: name (ret) [./~/shallowequal/index.js:3,0][main-df07a8a05e193c746606.js:91645,8]

The react-side-effect was released from 1.1.0 to 1.1.1 two hours ago, using shallowequal@1.0.0.