Dart-Code: "character must be non-negative" in inlay hints

Hit by @incendial at https://github.com/Dart-Code/Dart-Code/issues/4421#issuecomment-1464907624

workbench.desktop.main.js:615   ERR Illegal argument: character must be non-negative: Error: Illegal argument: character must be non-negative
	at w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:7:1267)
	at new p (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:13423)
	at new n (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:14913)
	at asRange (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:39344:24)
	at asLocation (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:39675:66)
	at asInlayHintLabelPart (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:40113:31)
	at convertBatch (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:41685:25)
	at Object.map (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:41694:17)
	at asInlayHint (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:40088:27)
	at convertBatch (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:41717:31)
	at async Object.mapAsync (/Users/dimannich/.vscode/extensions/dart-code.dart-code-3.61.20230307/out/dist/extension.js:41725:17)
	at async ee.provideInlayHints (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:98:49977)

About this issue

Original URL
State: closed
Created a year ago
Comments: 37 (16 by maintainers)

Commits related to this issue

Add some temporary debug logging for invalid inlay hints See #4436. — committed to Dart-Code/Dart-Code by DanTup a year ago
[analysis_server] Don't produce inlay hints for parameters without names Fixes https://github.com/Dart-Code/Dart-Code/issues/4436. Change-Id: I15e144134e0e16f93ad38f2c393b32a7d18749ed Reviewed-on: h... — committed to dart-lang/sdk by DanTup a year ago

Most upvoted comments

Well that’s very odd… I reproduced it twice, but when I started logging the issue stopped occurring. Even after a reload…

Although I did spot another issue with weird ranges coming back (filed #4454) and I wonder if they’re related (both are in some ways due to invalid locations).

DanTup on Mar 23, 2023

Thanks! I don’t know why the additional logging isn’t working, but I can repro. Taking a look, thanks!

DanTup on Mar 23, 2023