dapr: Use github.com/pkg/errors instead of fmt.errorf
In what area(s)?
/area runtime
Describe the proposal
we have used fmt.errorf to formatted error in the entire code bases, but this loses many information.
The other projects, such as Kubernetes, switched to https://github.com/pkg/errors to wrap errors in contextual information and still preserve the underlying error and originating stack trace.
instead of using fmt.errorf, we can use errors.Wrap and errors.Errorf in https://github.com/pkg/errors.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 25 (25 by maintainers)
Commits related to this issue
- replaced usage of fmt.Errorf and similar functions by github.com/pkg/errors for sentry as a part of work for #1954 — committed to jigargandhi/dapr by jigargandhi 4 years ago
- pkg/operator: replaced fmt.Errorf with error.wrap we have used fmt.errorf to formatted error in the entire code bases, but this loses many information. instead of using fmt.errorf, we can use errors... — committed to ShaileshSurya/dapr by ShaileshSurya 4 years ago
- Replaced fmt.Errorf by errors package using errors.Wrap (#1960) * replaced usage of fmt.Errorf and similar functions by github.com/pkg/errors for sentry as a part of work for #1954 * fix failing ... — committed to dapr/dapr by jigargandhi 4 years ago
- pkg/operator: replaced fmt.Errorf with error.wrap (#1962) * pkg/operator: replaced fmt.Errorf with error.wrap we have used fmt.errorf to formatted error in the entire code bases, but this loses m... — committed to dapr/dapr by ShaileshSurya 4 years ago
- replaced fmt.errors with pkg/errors for placement as per #1954 — committed to jigargandhi/dapr by jigargandhi 4 years ago
- replaced fmt.errors with pkg/errors for placement (#1970) as per #1954 — committed to dapr/dapr by jigargandhi 4 years ago
- pkg/injector:replace fmt.Errorf by error.wrap replacing fmt.Errorf by error.wrap from library https://github.com/pkg/errors. This wrap errors in contextual information and still preserve the underlyi... — committed to ShaileshSurya/dapr by ShaileshSurya 4 years ago
- pkg/injector:replace fmt.Errorf by error.wrap (#1980) replacing fmt.Errorf by error.wrap from library https://github.com/pkg/errors. This wrap errors in contextual information and still preserve th... — committed to dapr/dapr by ShaileshSurya 4 years ago
- used github.com/pkg/errors for http and runtime package refers #1954 — committed to jigargandhi/dapr by jigargandhi 4 years ago
- used github.com/pkg/errors for http and runtime package (#2078) refers #1954 Co-authored-by: Young Bu Park <youngp@microsoft.com> Co-authored-by: Yaron Schneider <yaronsc@microsoft.com> — committed to dapr/dapr by jigargandhi 4 years ago
I will take up
actorsandapinextI think, placement and sidecar injector still needs modification so the ticket should not be closed
@ShaileshSurya I can take up Sentry and placement and you can take up Operator and sidecar injector