dapr: Remove duplicated PB message definitions and refine gRPC API
In what area(s)?
/area runtime
Describe the feature
This is to remove the duplicated Protobuf message definition and rename gRPC service name properly
- Move
State,StateOptions,RetryPolicy, andStateRequestto dapr/proto/common/v1/ and share them in Dapr and DaprClient grpc service.- JS grpc generator complains about the duplicated definitions in Dapr and DaprClient cc/ @pruthvidhodda
- Rename
DaprClientgRPC Service name toAppCallbackDaprClientnaming makes user confused. We can think that DaprClient is used for Dapr gRPC API client. But, this gRPC is designed for AppChannel communication in user application.
- Use the consistent request and response message naming convention
- We use
xxxxEnvelopemessage name in some proto files while usingxxxRequest,xxxResponsemessage name in the other proto files. I am proposing to usexxxRequest,xxxResponsefor request and response msg naming conventions respectively.
- We use
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 24 (24 by maintainers)
Yes,
AppCallbackis good as well.Along those lines then,
AppCallbackwould be more suitable.You know how the Go linter claims you stutter if the type first word contains the package name?
So
dapr.DaprCallbackis weird, because the package name is already there. I thinkdapr.AppCallbackis cleaner in this case. WDYT?I support the usage of
Request/Response.Overall, LGTM.
Can you clarify what will be the naming convention for request/response?