node-ping: processBody windows bug

there is a case in windows that fails

this._times.push(parseFloat(match[1], 10));
TypeError: Cannot read property '1' of null

domain: hotel-capitol-kuala-lumpur.com

the error is in win.js

some answers are different

[ 'bytes=32', 'tiempo<1m', 'TTL=128' ]

they do not contain ms

var timeKVP = __.find(kvps, function (kvp) {
  return kvp.indexOf('ms') >= 0;
});

the solution is very easy. I hope you update it. a greeting

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 15 (5 by maintainers)

Most upvoted comments

yes, sorry I am very busy with other projects, but please do send a PR and as soon as @mondwan will confirm it I will try to push it upstream asap. thanks, dan

By the way, guys, could you please bump the package version? I just want to update my deps.

If you don’t mind, I can help.