swift: Inline not working
Hi! I just started integrating today with TravisCI and everything seems to be working except for the inline functionality. Version. 1.1.0.
I have two warnings in my PR and they both show up as a single comment block on the PR rather than inline.
Here’s some debug info:
Dangerfile.swift
// Dangerfile.swift
import Danger
let danger = Danger()
SwiftLint.lint(inline: true)
travis.yml, relevant portion
script:
- brew install danger/tap/danger-swift
- danger-swift ci
travis output, relevant portion
brew install danger/tap/danger-swift
==> Tapping danger/tap
Cloning into '/usr/local/Homebrew/Library/Taps/danger/homebrew-tap'...
Tapped 2 formulae (33 files, 27KB).
==> Installing danger-swift from danger/tap
==> Installing dependencies for danger/tap/danger-swift: danger/tap/danger-js
==> Installing danger/tap/danger-swift dependency: danger/tap/danger-js
==> Downloading https://github.com/danger/danger-js/releases/download/6.1.13/danger-macos.zip
==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws.com/66146807/bba00100-08e1-11e9-821a-3a349f659128?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20190117%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20190117T230137Z&X-Amz-Expires=300&X-Amz-Signature=c278cdbc61e177ed45e069c50e214ee16acbae2415b01e59d8bae3bdb5319d37&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Ddanger-macos.zip&response-content-type=application%2Foctet-stream
🍺 /usr/local/Cellar/danger-js/macos: 3 files, 79.9MB, built in 6 seconds
==> Installing danger/tap/danger-swift
==> Downloading https://github.com/danger/danger-swift/archive/1.1.0.tar.gz
==> Downloading from https://codeload.github.com/danger/swift/tar.gz/1.1.0
Warning: Cannot verify integrity of 941b66710bc97d4a61a81d1731cff50b886a61a1eae0f2fd42e1c491c58313e3--swift-1.1.0.tar.gz
A checksum was not provided for this resource
For your reference the SHA256 is: 9f67975999505ae35e9ff3fbe0130f73632366a4f2be415df4c05ada609cb9a4
==> make install PREFIX=/usr/local/Cellar/danger-swift/1.1.0
🍺 /usr/local/Cellar/danger-swift/1.1.0: 17 files, 12.4MB, built in 1 minute 41 seconds
The command "brew install danger/tap/danger-swift" exited with 0.
12.44s$ danger-swift ci
Executing swiftlint lint --quiet --path "Dangerfile.swift" --reporter json
Executing swiftlint lint --quiet --path "Shared/Constants/Constants.swift" --reporter json
Executing pwd
Found only warnings, not failing the build.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 16 (13 by maintainers)
@f-meloni Also found that code by now 😃 Though I haven’t figured out, whats going wrong there.
I think the full path is definitely the reason. When the warning is printed in our PR it has the full path in it, therefore it cannot inline on GitHub:
I think the path in the output above looks off, because @steven-diaz just scrubbed the repo name 😉