peril: Potential problem with github.utils.fileContents

I tried adding my very own danger-plugin-flow to our Peril setup (https://github.com/withspectrum/peril-settings), but as soon as I did that and added an unflowtyped file (to make the plugin fail to see whether it works or not) I got a “Bad credentials” error:

screen shot 2018-04-25 at 21 02 11

Any clues what could be happening here? I specifically used github.utils.fileContents instead of fs for Peril compat, but I might totally be missing something.

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 20 (20 by maintainers)

Most upvoted comments

OK, I’ll have a proper think about this over the weekend.

It should be possible to add support coalescing multiple runs to all happen sycnronously without a db, devoted some time to the idea on the airplane

I have a long flight tomorrow where I intend to work on #240 - so I’ll keep my eyes open for this too

Yeah, no, I woundn’t recommend digging into this one! The heart of the danger runner is super complex I’m afraid

But it’s something around this.