Report

Running danger using gem versions

Using danger 6.0.0
Using danger-plugin-api 1.0.0
...
Using danger-android_lint 0.0.6
Using ox 2.10.0
Using danger-checkstyle_format 0.1.1
...
Using gitlab 4.10.0
Using danger-gitlab 7.0.0

results in

Server responded with code 400, message: 400 (Bad request) "Note {:line_code=>["can't be blank", "must be a valid line code"]}" not given. Request URI: https://git.domain.com/api/v4/projects/my_project/merge_requests/2/discussions
body: <table data-meta="generated_by_danger">
  <tbody>
    <tr>
      <td>:warning:</td>
      <td width="100%" data-sticky="false">app/src/main/java/com/domain/project/SomeClass.kt#L1Needless blank line(s)</td>
    </tr>
  </tbody>
</table>

position: {:position_type=>"text", :new_path=>"app/src/main/java/com/domain/project/SomeClass.kt", :new_line=>1, :base_sha=>"727a60e3b24bfcba507b3d8687b1a428c73f5e4d", :start_sha=>"727a60e3b24bfcba507b3d8687b1a428c73f5e4d", :head_sha=>"378f448b7a41cc43b67a98855fd2c39e1398cb22"}
/var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:425:in `rescue in block in submit_inline_comments_for_kind!': undefined method `[]' for nil:NilClass (NoMethodError)
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:402:in `block in submit_inline_comments_for_kind!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:374:in `reject'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:374:in `submit_inline_comments_for_kind!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:335:in `submit_inline_comments!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:187:in `update_pull_request_with_inline_comments!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:154:in `update_pull_request!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/danger_core/dangerfile.rb:247:in `post_results'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/danger_core/dangerfile.rb:278:in `run'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/danger_core/executor.rb:29:in `run'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/commands/runner.rb:72:in `run'
	from /var/lib/gems/2.6.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/bin/danger:5:in `<top (required)>'
	from /usr/local/bin/danger:23:in `load'
	from /usr/local/bin/danger:23:in `<main>'
/var/lib/gems/2.6.0/gems/gitlab-4.10.0/lib/gitlab/request.rb:67:in `validate': Server responded with code 400, message: Bad Request. Request URI: https://git.domain.com/api/v4/projects/my_project/merge_requests/2/discussions/2a8634d25f816bbefefe629998db4533905a8a7f/notes/36227 (Gitlab::Error::BadRequest)
	from /var/lib/gems/2.6.0/gems/gitlab-4.10.0/lib/gitlab/request.rb:46:in `block (2 levels) in <class:Request>'
	from /var/lib/gems/2.6.0/gems/gitlab-4.10.0/lib/gitlab/client/merge_requests.rb:284:in `update_merge_request_discussion_note'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:422:in `block in submit_inline_comments_for_kind!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:374:in `reject'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:374:in `submit_inline_comments_for_kind!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:335:in `submit_inline_comments!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:187:in `update_pull_request_with_inline_comments!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/request_sources/gitlab.rb:154:in `update_pull_request!'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/danger_core/dangerfile.rb:247:in `post_results'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/danger_core/dangerfile.rb:278:in `run'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/danger_core/executor.rb:29:in `run'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/lib/danger/commands/runner.rb:72:in `run'
	from /var/lib/gems/2.6.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
	from /var/lib/gems/2.6.0/gems/danger-6.0.0/bin/danger:5:in `<top (required)>'
	from /usr/local/bin/danger:23:in `load'
	from /usr/local/bin/danger:23:in `<main>'

Your Environment

• Which CI are you running on?

GitLab 11.8.0 (ce13864)

• What is your Dangerfile?

declared_trivial = (gitlab.mr_title + gitlab.mr_body).include?("trivial")

warn("MR is classed as Work in Progress") if gitlab.mr_title.include? "[WIP]"

failure "Please provide a summary in the Merge Request description" if gitlab.mr_body.length < 5

# Warn when detekt config has changed
warn("Detekt config has changed") if git.modified_files.include? "detekt-config.yml"

# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500

# detekt
checkstyle_format.base_path = Dir.pwd
checkstyle_format.report "/builds/hireme/hireme-android/app/build/reports/detekt/detekt.xml"

# AndroidLint
android_lint.report_file = "app/build/reports/lint-results.xml"
android_lint.lint(inline_mode: true)