webots: Sumo still crashing in `highway_overtake.wbt`
Describe the Bug There appears to still exist problems with sumo.
Steps to reproduce:
- Open
highway_overtake.wbt - Let it run a lot. It might take 30 simulated minutes, sometimes 1 hour before it crashes.
It doesn’t appear to be a regression, the crash fixed here happened almost immediately, so this one might have gone unnoticed.
The crash affects both ubuntu 20 and windows
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 20 (20 by maintainers)
Commits related to this issue
- Fix crash in Highway_overtake.wbt #3556 due to acos getting out of valid range value causing a NaN valid to be generated. This in turn is assigned to a WbRotation angle which triggers an infinite noti... — committed to cyberbotics/webots by llessieux 3 years ago
- Fix crash in Highway_overtake.wbt #3556 due to acos getting out of va… (#3734) * Fix crash in Highway_overtake.wbt #3556 due to acos getting out of valid range value causing a NaN valid to be generat... — committed to cyberbotics/webots by llessieux 3 years ago
- Merge master into develop (#3735) * Fix Laser intersecting transparent objects #3468 (#3726) * Fix Laser intersecting transparent objects #3468 * Update src/webots/nodes/WbGeometry.hpp Co-au... — committed to cyberbotics/webots by ad-daniel 3 years ago
- Merge master into develop (#3735) (#3737) * Fix Laser intersecting transparent objects #3468 (#3726) * Fix Laser intersecting transparent objects #3468 * Update src/webots/nodes/WbGeometry.hpp ... — committed to cyberbotics/webots by ad-daniel 3 years ago
- Fix acos issues (#3741) * Fix crash in Highway_overtake.wbt #3556 due to acos getting out of valid range value causing a NaN valid to be generated. This in turn is assigned to a WbRotation angle whi... — committed to cyberbotics/webots by llessieux 3 years ago
I don’t mind updating the code 😉 So add an assert checking that the value is within the range with some epsilon value? Does that sounds ok to everybody?
Propagating the NaN will just break everything and it will take a while to figure out where it went wrong because the side effect can be quite far from the cause 😉 Took me half a day (but then again I am on Windows and using Visual Studio to debug so perhaps not the best way 😉 to get to the root of the issue.
Yes, that sounds good. Please go ahead with the implementation and propose a PR. I will be happy to review it.
Yes I should be able to get to the root of the issue. My guess is that the normalize of the angle is the issue but I will try to get the exact values causing the problem.