jss: devDependencies do not work in Node 7

I wanted to send pull request but just increasing a version is not enough. devDependencies won’t install on Node 7 because of codecov which uses deprecated version of graceful-fs and this is the latest version of codecov.

❯ npm i
npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

...

❯ npm ls graceful-fs
jss@5.5.5 /Users/tema/jss
...
├─┬ codecov@1.0.1
│ └─┬ execSync@1.0.2
│   └─┬ temp@0.5.1
│     └─┬ rimraf@2.1.4
│       └── graceful-fs@1.2.3
...

They have an issue for that since June: https://github.com/codecov/codecov-node/issues/19.

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 20 (18 by maintainers)

Commits related to this issue

Chore: Temporarily disable Node 7 because of JSS https://github.com/cssinjs/jss/issues/338 — committed to styleguidist/react-styleguidist by sapegin 8 years ago
Merge pull request #369 from sapegin/engines Require Node 4+ (fix #338) — committed to cssinjs/jss by kof 8 years ago

Most upvoted comments

yes!

kof on Nov 23, 2016

Contribution guidelines I think is the best place since there’s no way to separate engine requirements.

sapegin on Nov 23, 2016

I’m thinking about the right solution for this problem because it also won’t install in Node 4. And yarn treat engines as a an error, while npm as just a warning.

Probably we should use engines only to specify requirements for package consumers, not for developers. For JSS I’d set it for >= 4.

For developers engine field of packages in devDependencies should be used. For example if you have eslint in devDependencies it won’t install on Node 0.12 no matter what you have in engines yourself.

What do you think?

sapegin on Nov 23, 2016