cri-o: `test/checkpoint.bats` tests don't work on `linux/arm64`
https://github.com/cri-o/cri-o/pull/7620 shows that the tests have to be disabled to let the CI pass on the linux/arm64 platform.
Goal of this issue is to investigate why the tests fail and fix them appropriately.
/help /good-first-issue
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 31 (22 by maintainers)
Commits related to this issue
- Run checkpoint restore tests on arm We patch the container file to match CI requirements. See: https://github.com/cri-o/cri-o/issues/7629#issuecomment-1951356893 Signed-off-by: Sascha Grunert <sgru... — committed to saschagrunert/cri-o by saschagrunert 3 years ago
- Run checkpoint restore tests on arm We patch the container file to match CI requirements. See: https://github.com/cri-o/cri-o/issues/7629#issuecomment-1951356893 Signed-off-by: Sascha Grunert <sgru... — committed to saschagrunert/cri-o by saschagrunert 3 years ago
Cool. From my point of view that should be an acceptable workaround for now. Disabling “restartable sequences” from my understanding should not be a problem.
Those settings were added as requested.
Firecracker runs a very minimal Kernel, we had to work really hard to add everything in for containers, then for BPF, then for BTF etc.
That was a quick turnaround, nice.
To fix the next errors something like this might be needed:
CONFIG_UNIX_DIAG=y CONFIG_INET_DIAG=y CONFIG_INET_UDP_DIAG=y CONFIG_PACKET_DIAG=y CONFIG_NETLINK_DIAG=y CONFIG_NETFILTER_XT_MARK=y CONFIG_INET_TCP_DIAG=y CONFIG_INET_UDP_DIAG=y CONFIG_INET_RAW_DIAG=y
There is an outdated page what needs to exist: https://criu.org/Linux_kernel
From that page I know that
CONFIG_MEM_SOFT_DIRTY=ydoes not exist on arm64. Besides that most of those options should be turned on.Yes, that is the problem. Looking at
https://github.com/torvalds/linux/blob/master/kernel/ptrace.c#L363
I am pretty sure they do not have
CONFIG_CHECKPOINT_RESTORE=yin their kernel config.Do you have any way to request that?
@prakrit55 that is irrelevant
@saschagrunert, I would like to give it a try