coverlet: InstrumentationHelper.HasPdb always returns false for deterministic source paths

I’m not sure about it…at the moment we have 3 drivers(.net tool,msbuild,collectors) and not all version supports all features, have single version could confuse users.

FWIW, I think it could be okay to keep drivers at the same version long as what’s in each is documented somewhere. If they all tend to rely on an underlying core library, then that could be what drives the main version. Totally up to you though of course.

Plan

• msbuild support https://github.com/tonerdo/coverlet/pull/796
• collectors support https://github.com/tonerdo/coverlet/pull/802
• add new integration tests https://github.com/tonerdo/coverlet/pull/811
• add workaround documentation

Proposal:

1. Short term: Only coverlet.collector or coverlet.msbuild will support DeterministicSourcePaths. It can do so by adding a target that writes the PathMap’s to the output directory alongside the target dll’s. This target may need to be added at the Directory Props level to work, next to the Source Link reference.
2. Better: SourceLink / the SDK writes this out built-in.

In both cases, build tools that need to read this data can open the PathMap file and do the translation needed.

Thoughts?

@MarcoRossignoli Here’s a repro case:

1. Check out dotnet/roslyn-analyzers#3028
2. Build with .\Build.cmd -rebuild /p:DeterministicSourcePaths=true
3. Test with .\Test.cmd /p:Coverage=True

Expected results:

Coverage files in artifacts\coverage have coverage information.

Actual results:

Coverage files are empty.

Additionally, it should have a try … catch block, because peReader.ReadDebugDirectory() can fail.

Part of this fixed in https://github.com/tonerdo/coverlet/pull/367/files