cosmos-sdk: perf: bech32 library, implement a decode algorithm that doesn't check the checksum

Summary

Now that we are using bech32 strings in several locations within the state machine (e.g. all the proto structs for staking), we should be mindful of the efficiency. Bech32 decoding for checksum checks with the current implementation checks isn’t negligible time at scale, especially if your doing a large operation over state. (E.g. in epoch based models)

Any bech32 address that makes it into state should be a correct bech32 address. Therefore, we do not need to check its checksum upon decoding. We should implement a method in our bech32 library for DecodeAssumingValidChecksum

Problem Definition

This feature helps improve performance of going to and fro ‘native’ data representation, and bech32 strings, for objects within the state machine.

The downside of this feature is it may add some additional thinking to relevant parts of the logic, for something that in the “standard” path of the SDK (e.g. not a large batch computation), will not be high impact.

Proposal

In the bech32 library we currently use, add a method for DecodeAssumingValidChecksum that simply omits the bech32verifychecksum call

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned