commitlint: require() of ES Module /xxx/commitlint.config.js from /xxx/node_modules/cosmiconfig/dist/loaders.js not supported. Instead change the require of commitlint.config.js in /xxx/node_modules/cosmiconfig/dist/loaders.js to a dynamic import() which is available in all CommonJS modules.

The resolve-extends issue might be resolved by https://github.com/conventional-changelog/commitlint/issues/3705; is that updating the entire package to use ESM?

That issue is just a reminder that commitlint in general should be switched to ESM. I opened this up because we already have dep updates being blocked by this (at least I think that’s the case).

Unfortunately, this specific case can’t be covered in the Jest tests; trying to use the dynamic import in node < 20.8.0 will cause a seg fault and prevent the test from finishing. But I was able to verify the change manually with linking to another repo.

So people who use v20 should use at least use 20.8? Sounds good to me. CI would pass, right?

I also noticed that the resolve extends package doesn’t do well with ESM since it uses require to load additional extended config, but I wasn’t able to get something working for that. I can make a new issue to address it since it’s unrelated.

Is this part of or just #3705 maybe?

Thanks for all your work!

Technically the async loaders will work in source code with other node versions, but for the purposes of the tests, the sync loaders should be used (this was also the previous behavior because before cosmiconfig 8.2.0, the async loaders used commonJS like the sync loaders do now). I’ve set up the tests to skip the ones that would cause Jest to crash.

The resolve-extends issue might be resolved by #3705; is that updating the entire package to use ESM? There may be similar test issues as the ones seen in the cosmiconfig update as a heads up.

@escapedcat @pfdgithub I’d like to simplify the original implementation for this - basically use the async loaders if dynamic await is supported (node > 20.8.0) OR config is an ESM module application. Otherwise, use the sync loaders. I almost have some additional tests ready to push to cover additional cases, and code changes are minor, similar to the PR. Unfortunately, this specific case can’t be covered in the Jest tests; trying to use the dynamic import in node < 20.8.0 will cause a seg fault and prevent the test from finishing. But I was able to verify the change manually with linking to another repo.

I also noticed that the resolve extends package doesn’t do well with ESM since it uses require to load additional extended config, but I wasn’t able to get something working for that. I can make a new issue to address it since it’s unrelated.

Sorry, PR3772 used the wrong email address

I guess so, yes. 18.3 working for you?

Strangely, I deleted the node_modules and package-lock.json files and downgraded to versions @commitlint/cli@18.2.0 and @commitlint/config-conventional@18.1.0, which were the normal versions I used before, but I still get the error.

% npm list @commitlint/cli

└── @commitlint/cli@18.2.0

% npm list @commitlint/config-conventional

└── @commitlint/config-conventional@18.1.0

% npm list cosmiconfig                                                                          
├─┬ @commitlint/cli@18.2.0
│ └─┬ @commitlint/load@18.4.1
│   ├─┬ cosmiconfig-typescript-loader@5.0.0
│   │ └── cosmiconfig@8.3.6 deduped
│   └── cosmiconfig@8.3.6
└─┬ @svgr/rollup@8.1.0
  ├─┬ @svgr/core@8.1.0
  │ └── cosmiconfig@8.3.6 deduped
  └─┬ @svgr/plugin-svgo@8.1.0
    └── cosmiconfig@8.3.6 deduped

The problem seems to be with @commitlint/load