operational-ui: AvatarGroup negative margin breaks design
Here’s a demo of the problem.
The Problem
In AvatarGroup, each constituent Avatar has margin-left: -12px, which breaks their composition into any box model.
The Solution
Only apply the negative margin to every Avatar after the first one.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 4
- Comments: 23 (19 by maintainers)
@DillionM, you have all the permission to not understand and that is totally fine!
To explain a bit,
this is an issue. It’s a place where we (the community) list stuff that we need to work on in the project. Think of it as a “to do list”.
when someone (in this case @mehtavishwa30) chooses to work on it, they fix the issue and open a pull request. They kind of look like this and allow us to see what’s being added/removed from the project and review it to make sure we’re all on the same page.
if we approve it, then @mehtavishwa30’s work becomes part of this project and the issue gets resolved (we check the item of the to do list) and continue to create better software together.
Does that clarify things a bit? Or was your question more about this specific issue?
Permit me to say I don’t understand what’s going on here… I’m a GitHub newbie ☹️
@winniebosy @bradd123 hey y’all, thanks for getting involved but these issues are on a first-come-first-serve basis. I believe @mehtavishwa30 already started on it so it would only be fair to her that we let her finish it.
@winniebosy that means there aren’t really any other
good first issues left for you to choose from. We might ping you later if something comes up. I hope that’s okay! 😄@bradd123, that’s great feedback! It seems there are 2 TS errors. 🤔 I’ll investigate this in https://github.com/contiamo/operational-ui/issues/1077 and see what’s broken. Thanks for pointing that out!
Nothing specific. Everything should be in the README. Looking forward to your PR.