toolbox: toolbox run does not work when no tty is attached
the current implementation of run() always uses the flags --interactive and --tty for podman exec. i’m using toolbox run mostly from dmenu, so there is no tty attached. Maybe --tty and --interactive should only be used when enterning a container.
will create a pull request asap.
thanks toni
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 18 (10 by maintainers)
Commits related to this issue
- cmd/run: Don't allocate pseudo-TTY if not connected to terminal Passing '--tty' to 'podman exec' unconditionally causes Podman to allocate a pseudo-TTY for the command execution. This causes problems... — committed to HarryMichal/toolbox by HarryMichal 2 years ago
- test/system: Remove workaround for carriage return without a terminal Commit a22d7821cb8cea13 ensured that a nested pseudo-terminal device is only created for the process running inside the container... — committed to debarshiray/toolbox by debarshiray 2 years ago
- cmd/run: Don't allocate pseudo-TTY if not connected to terminal Passing '--tty' to 'podman exec' unconditionally causes Podman to allocate a pseudo-TTY for the command execution. This causes problems... — committed to emtee40/linux-toolbox by HarryMichal 2 years ago
I wrote almost the same script for myself! It also allocates a TTY if stdin is a terminal which helps with some interactive commands. https://gist.github.com/jmou/55111caa23d9aeb777ff70c89b9ceffb
Thank you @HarryMichal for fixing this!