concretecms: Wrong migrations in 8.5.3 and 8.5.4
The latest migration in 8.5.2 is 20190925072210 (see here and here).
In next 8.5.x releases, a few commits from the develop branch has been merged, but these commits contain migrations with an identifier lower than 20190925072210.
This can be seen by comparing migration files between 8.5.2 and 8.5.4 with:
diff -c3 \
<(printf '%s\n' $(git ls-tree tags/8.5.2 concrete/src/Updater/Migrations/Migrations/ | cut -d '/' -f 6)) \
<(printf '%s\n' $(git ls-tree tags/8.5.4 concrete/src/Updater/Migrations/Migrations/ | cut -d '/' -f 6))
which outputs
*** 135,146 ****
--- 135,163 ----
Version20190225000000.php
Version20190225184524.php
Version20190301133300.php
+ Version20190309000000.php
+ Version20190310000000.php
+ Version20190416224702.php
+ Version20190417180607.php
+ Version20190422235040.php
+ Version20190504005632.php
+ Version20190508232235.php
+ Version20190509205043.php
+ Version20190513164028.php
Version20190516204806.php
Version20190520171430.php
+ Version20190522202749.php
+ Version20190619141521.php
Version20190625177700.php
Version20190625177710.php
+ Version20190708000000.php
Version20190717090600.php
Version20190817000000.php
Version20190822160700.php
Version20190826000000.php
Version20190925072210.php
+ Version20191002000000.php
+ Version20200118043285.php
+ Version20200203000000.php
+ Version20200501000000.php
+ Version20200609145307.php
As you can see, in 8.5.4 we have these new migrations before 20190925072210:
20190309000000
20190310000000
20190416224702
20190417180607
20190422235040
20190504005632
20190508232235
20190509205043
20190513164028
20190522202749
20190619141521
20190708000000
So, when upgrading from 8.5.2 to 8.5.4, those migrations may not be executed.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 2
- Comments: 18 (18 by maintainers)
We failed to update from 8.5.2 to 8.5.5 on one of the websites we maintain.
I made a script to check which migrations are not run. https://gist.github.com/hissy/349370d0a67f90f185dd179f561705f0
I originally submitted this issue because I’ve had a few problems upgrading a website of us from concrete5 8.5.2 to 8.5.4.
BTW I just migrated 6 of our websites from concrete5 8.5.2 to 8.5.4, and I didn’t experience any migration issue. Maybe when I saw the problem I badly replicated the production server when I tested the upgrade.
So, IMHO we can close this issue (but for consistency I’d still keep the tests about the progressive migration keys).