concourse: fly login does not allow enough characters to paste in bearer token

@aoldershaw I was tempted to use something like github.com/atotto/clipboard to have fly grab the token off your clipboard, but then I realized if we’re able to directly access the token on your clipboard from fly (or pbpaste) you probably wouldn’t be in this situation in the first place.

This tends to happen when you’re using fly remotely, i.e. over SSH - so it’d be a different machine without access to your clipboard. So whatever approach we take probably has to work in that context.

This issue is so annoying haha.

@bmhkb4 Yeah - now that we just use the tokens issued directly by Dex, they can be much larger. For example, if you log in with GitHub the token will contain a list of all of your teams (x2 - one for team name, one for team slug) and organizations. This data is used by the API endpoints to check against the requested team’s configured list of authorized users/teams/orgs/etc.

Previously this limit could only be hit if you were a member of many Concourse teams, since team names were encoded in the token, which is probably less common.

I found the place where we talked about this before – and @cirocosta found a similarly sinister constant: https://github.com/concourse/concourse/issues/4339#issuecomment-527161365

@vito I’m using iTerm on macOS Catalina. The token I’m copying is ~2000 characters long, looks like it’s getting capped at 1024 characters.

@jamieklassen I tried using iTerm and terminal on macOS, both had the same issue. I had trouble installing aminal, so I haven’t tested it on something else yet.

Worth noting that when I just run read and try to paste my token, it stops it at the same 1024 character limit, so definitely seems to be the buffer limit like you mentioned. Although this isn’t explicitly a concourse issue, maybe it’s something that needs to change about the instructions presented for fly login given it seems to affect both macOS and Linux out of the box?