concourse: --docker-registry doesn't work

Bug Report

I’m trying to use our own docker artifactory as the default place to pull images. I did some try today on a 5.0 cluster.

By passing some environment variables to concourse worker, I can see that gdn has got --docker-registry option:

root 26 6 0 07:45 ? 00:00:02 gdn server --bind-ip 0.0.0.0 --bind-port 7777 --depot /worker-state/depot --properties-path /worker-state/garden-properties.json --time-format rfc3339 --no-image-plugin --docker-registry my.artifactory.eng.vmware.com --insecure-docker-registry my.artifactory.eng.vmware.com --dns-server 172.18.0.4 --allow-host-access

Then I submit a basic pipeline to the cluster with specifying an image path of my docker artifactory, but Concourse failed to pull the image, so looks like --docker-registry doesn’t work.

Steps to Reproduce

Exports envs:

  CONCOURSE_GARDEN_DOCKER_REGISTRY=my.artifactory.eng.vmware.com
  CONCOURSE_GARDEN_INSECURE_DOCKER_REGISTRY=my.artifactory.eng.vmware.com

then start worker.

Expected Results

Worker is expected to use my.artifactory.eng.vmware.com as the default registry.

Actual Results

Cannot pull image from my.artifactory.eng.vmware.com.

Version Info

• Concourse version: 5.0
• Deployment type (BOSH/Docker/binary): Docker
• Infrastructure/IaaS: docker-compose
• Browser (if applicable): any
• Did this used to work? no