apps-android-commons: Fix the 36 unit tests that started failing when switching from MapBox to OpenStreetMap (now set as @Ignored)

The switch from MapBox to OpenStreetMap was urgent, and unit tests were not considered a priority, so they have been set as ignored. Now we need to re-instate these unit tests.

Step 1: Remove all @Ignore added in this commit: https://github.com/commons-app/apps-android-commons/commit/5df18fb4a6f7c105b3a7d14526c08a0d1dd8f9ad Step 2: Make the unit tests pass Step 3: Send a pull request. 😃

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 16 (15 by maintainers)

Commits related to this issue

Most upvoted comments

tamojitdas/apps-android-commons@2c9badb2e7b715c9705d835108897c2b9670b792 posting here some updates made in forked repo …need to work on this for the next week as some changes has been done in the NearbyParentFragmentPresenterTest.kt class and others from the remote repo …hence had to sync & update accordingly …but will be sending the PR next week…Thanks

tamojitdas/apps-android-commons@d6ab627eff60b7ba62f118484521e8ef83ceeac2 progress update. Done with NearbyParentFragmentPresenterTest.kt few remaining on NearbyParentFragmentUnitTest.kt will try sending the PR tommorow.

thanks @kanahia1 for the info

Sure, will raise a PR in about 2 days, Will be assigning you and @nicolas-raoul to review I have some points to discuss with you Both…will be giving details in PR comments…Thanks

tamojitdas/apps-android-commons@4cf854bb94a63bb85e17ceba0e46ece7080d4e68 posting here the progress made in forked repo

Sure @axelthepony27 will let you know For any help needed

still working on the unit tests …will be able to send some updates in mid next week