minify: Bug: transform code to unsafe code

This lib will transform this code typeof(a) !== 'undefined' to (a)!==void 0, when β€˜a’ is not defined, will introduce JS error.

About this issue

  • Original URL
  • State: closed
  • Created 9 months ago
  • Reactions: 2
  • Comments: 20 (20 by maintainers)

Commits related to this issue

Most upvoted comments

It works fine since yesterday. I think we can close this issue and may it never return.

Thanks, for now it looks good. But let me confirm again tomorrow just to make sure that the bug is killed for good πŸ˜„

Just landed an update πŸŽ‰, please re-install Minify, is it works for you?

Ok, so that means refresh Deno cache: deno run -r main.ts

It works nice, thanks.

May I suggest to stop mangle top-level function name? Or just completely stop mangle every name? The mangleClassNames is not enough.

Just landed support of option mangle, now you can disable all mangle πŸŽ‰ . Please re-install Minify, is it works for you?

This lib will transform this code typeof(a) !== β€˜undefined’ to (a)!==void 0, when β€˜a’ is not defined, will introduce JS error.

Just fixed πŸŽ‰. Please re-install Minify, is it works for you?

You should be extremely careful with mangling code man. Please refer this case if you wish to improve it: https://code.visualstudio.com/blogs/2023/07/20/mangling-vscode