code-server: [Bug]: PWA Icon Doesn't Display When Using Reverse Proxy

Is there an existing issue for this?

I have searched the existing issues

OS/Web Information

Web Browser: Safari
Local OS: iPadOS 15.5
Remote OS: Libreelec (Linux Server Docker)
Remote Architecture: x86_64
code-server --version: v4.4.0

Steps to Reproduce

Reverse Proxy code-server
Open code-server via the proxied subdomain on an iPad using Safari
Tap the Share Button
Press Add to Home Screen

Expected

The home screen icon should resemble the favicons in the favicon folder

Actual

See the home screen icon which is a screenshot of the VS Code workbench (current page view)

Logs

No response

Screenshot/Video

Does this issue happen in VS Code?

I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

I am using HTTPS.

Notes

Tried to add favicon routes using Nginx but that didn’t work either.

About this issue

Original URL
State: open
Created 2 years ago
Comments: 16 (7 by maintainers)

Most upvoted comments

Have you signed with services like Let’s Encrypt? I think iOS will not load the icon if you manually trust the certificate (like the default certificate).

I have my reverse proxy signed with Let’s Encrypt but code-server is HTTP.

louisefindlay23 on Jun 19, 2022

Have you signed with services like Let’s Encrypt? I think iOS will not load the icon if you manually trust the certificate (like the default certificate).

icui on Jun 18, 2022

Sure: https://github.com/home-assistant/frontend/issues/12931

louisefindlay23 on Jun 14, 2022

No, I haven’t but have just done so. Will let you know what they say.

louisefindlay23 on Jun 11, 2022