code-server: [Bug]: Firefox not showing Jupyter file

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Firefox 102
  • Local OS: Win10
  • Remote OS: Ubuntu Focal
  • Remote Architecture: 86
  • code-server --version: 4.5.0 (About shows 4.4.0)

Steps to Reproduce

  1. Setup new docker instance
  2. Create test.ipynb file (doesnt matter if vscode-jupyter is installed or not)
  3. Open file with Firefox

Expected

Should show cells and Html Rendering

Actual

Endless Loading

Logs

Firefox Console (other browsers do not show this)


Uncaught (in promise) Error: Unable to write file 'vscode-log:/20220712T210007/window.log' (Error: IndexedDB database 'vscode-web-db' is closed.)
    h https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:9
    L https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:593
    writeFile https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:597
    _log https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:598
    consume https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:71
    queue https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:71
    queue https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:71
    _log https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:597
    error https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:597
    error https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:597
    _log https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:597
    error https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:597
    handleUnexpectedError https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:3072
    registerErrorHandler https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:3072
    onUnexpectedError https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:8
    R https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:8
    registerErrorHandler https://example.tld/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/workbench.web.main.js:3072
3 errors.ts:235
This page uses the non standard property “zoom”. Consider using calc() in the relevant property values, or using “transform” along with “transform-origin: 0 0”. example.tld
The web worker extension host is started in a same-origin iframe! webWorkerExtensionHost.ts:111:11
 INFO [Service Worker] registered log.ts:301:11
An iframe which has both allow-scripts and allow-same-origin for its sandbox attribute can remove its sandboxing. example.tld
The character encoding of a framed document was not declared. The document may appear different if viewed without the document framing it. webWorkerExtensionHostIframe.html
An iframe which has both allow-scripts and allow-same-origin for its sandbox attribute can remove its sandboxing. example.tld

Screenshot/Video

Firefox ( also tested with new installation / different machine / vm etc.): Screenshot 2022-07-12 204315

Other Browsers I tested (Opera, Chrome, Vivaldi, in this screenshot Edge) Screenshot 2022-07-12 204122

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 43 (22 by maintainers)

Commits related to this issue

Most upvoted comments

I have a containerized environment that launches in the cloud (free) via binder here: https://mybinder.org/v2/gh/ml-starter-packs/microservice-workshop/main?urlpath=vscode/ (Dockerfile).

latest commit pins codeserver to 4.5.1, and I found

  • terminal functioning as expected
  • notebooks working

~Its working with 4.5.1. Thanks.~

Can confirm that this bug doesn’t occur on 4.4.0

But I dont get how it can only affect one browser.

@H4Njx My JupyterLab Python docker stack is publicly available.

Repository: https://github.com/b-data/jupyterlab-python-docker-stack:

Usage > Build image:

cd base && docker build \
  --build-arg PYTHON_VERSION=3.11.4 \
  -t jupyterlab/python/base \
  -f latest.Dockerfile .

latest.Dockerfile: https://github.com/b-data/jupyterlab-python-docker-stack/blob/main/base/latest.Dockerfile 👉 Have a look at the conf files and scripts, too. Some are essential to make it all work together.

Other JupyterLab docker stacks (which also include Python v3.11.4):

ℹ️ Dev Containers for use with Codespaces are a work in progress and will be available soon.

thank you so much.

Cannot reproduce bug with latest version

I tested this today and it worked as expected.

Steps to Reproduce

  1. download latest code-server - v4.6.0-rc.1
  2. run code-server and open in Firefox
  3. Install Python/Jupyter extensions
  4. Open Jupyter file

Expected

It shows the Jupyter file and runs code.

Actual

It shows the Jupyter file and runs code.

Screenshot

image

Since VS Code (assumingely) tests this on their own, we decided not to add an e2e test for now. If we find out one of our patches introduces a bug or something breaks in the future, we will revisit adding a test.

Closing this for now.

Please test for yourself and tell me if you have the same problem. (firefox)

Initially, I had the same problem with your deployment.

Then I cleared all history

clear-all-history

and never had the problem again:

Firefox

Sometimes its working. Sometimes not. With 4.4.0 its working everytime.

But thanks for solving it in theory.

It runs just smoothly [also in practice] at https://demo.jupyter.b-data.ch 😉.

I removed the docker container and recreated it and now its working so far. I hope it stays that way, cause i did that already several times, so it seems inconsistent for me. But thanks for solving it in theory.

Hooray! Thank you @benz0li for testing and confirming!

@Emporea @mathematicalmichael Please test again with code-server 4.5.1.

Most probably related to https://github.com/coder/code-server/issues/5321.

FYI code-server 4.5.1 is working fine with ms-toolsai.jupyter@2022.5.1001610507 and ms-python.python@2022.10.1.

@mathematicalmichael hooray! that’s great to hear.

We really need to add some e2e tests for Jupyter. I’m going to add this to the next sprint.

Is this a duplicate of #5335?

No.

Or are they somehow related?

No, they are not.

@Emporea for me it is impacting all browsers I have installed. @jsjoeio thank you very much for investigating! 4.4.0 is the first version where Jupyter notebooks actually function and it makes me so happy to finally be able to use code-server exclusively for my work.

Ah got it. Okay We’ll investigate!

@jsjoeio I don’t know how they are related (atleast they share downgrading to 4.4.0 as a workaround), but this is definitly not a duplicate.