cmssw: Unit test and workflow failures because of illegal characters in MonitorElement path name

The unit test testSiStripDQM_OfflineTkMap started to fail in CMSSW_12_5_X_2022-07-28-1100 with a segfault

Thu Jul 28 12:47:37 CEST 2022
Thread 1 (Thread 0x2aab6c76d1c0 (LWP 3183) "cmsRun"):
#3  0x00002aab71b25aeb in sig_dostack_then_abort () from /cvmfs/cms-ib.cern.ch/nweek-02743/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-07-24-0000/lib/el8_amd64_gcc10/pluginFWCoreServicesPlugins.so
#4  <signal handler called>
#5  0x00002aab9ba2767c in TkHistoMap::getValue(DetId) () from /cvmfs/cms-ib.cern.ch/nweek-02743/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-07-24-0000/lib/el8_amd64_gcc10/libDQMSiStripCommon.so
#6  0x00002aab9b8bc5ea in SiStripTrackerMapCreator::createInfoFile(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, TTree*, dqm::legacy::DQMStore&, GeometricDet const*) () from /cvmfs/cms-ib.cern.ch/nweek-02743/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-07-24-0000/lib/el8_amd64_gcc10/libDQMSiStripMonitorClient.so
#7  0x00002aab9b8581c0 in SiStripOfflineDQM::endRun(edm::Run const&, edm::EventSetup const&) () from /cvmfs/cms-ib.cern.ch/nweek-02743/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-07-24-0000/lib/el8_amd64_gcc10/pluginDQMSiStripMonitorClientPlugins.so
#8  0x00002aab69307479 in edm::one::EDProducerBase::doEndRun(edm::RunTransitionInfo const&, edm::ModuleCallingContext const*) () from /cvmfs/cms-ib.cern.ch/nweek-02743/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-28-1100/lib/el8_amd64_gcc10/libFWCoreFramework.so
#9  0x00002aab692eb5e0 in edm::WorkerT<edm::one::EDProducerBase>::implDoEnd(edm::RunTransitionInfo const&, edm::ModuleCallingContext const*) () from /cvmfs/cms-ib.cern.ch/nweek-02743/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-28-1100/lib/el8_amd64_gcc10/libFWCoreFramework.so

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc10/CMSSW_12_5_X_2022-07-28-1100/unitTestLogs/DQM/SiStripMonitorClient#/

The cause probably lies in the beginning of the log

Running script: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-28-1100/src/DQM/SiStripMonitorClient/test/test_SiStripDQM_OfflineTkMap.sh
xrdfs command status = 0
Using file /store/group/comm_dqm/DQMGUI_data/Run2018/ZeroBias/R0003191xx/DQM_V0001_R000319176__ZeroBias__Run2018B-PromptReco-v2__DQMIO.root and run 319176. Running in /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-28-1100/src/DQM/SiStripMonitorClient/test.
----- Begin Fatal Exception 28-Jul-2022 12:47:03 CEST-----------------------
An exception of category 'BadMonitorElementPathName' occurred while
   [0] Processing global begin Run run: 319176
   [1] Calling method for module SiStripOfflineDQM/'siStripOfflineAnalyser'
Exception Message:
 Monitor element path name: 'root://cms-xrd-global.cern.ch//store/group/comm_dqm/DQMGUI_data/Run2018/ZeroBias/R0003191xx/DQM_V0001_R000319176__ZeroBias__Run2018B-PromptReco-v2__DQMIO.root:/DQMData/Run 319176/CSC/By Lumi Section 393-393/EventInfo/reportSummaryMap' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
----- End Fatal Exception -------------------------------------------------

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 16 (16 by maintainers)

Most upvoted comments

Is it the comma that’s wrong? Yes.

There are actually two problems with path name. The comma here

https://github.com/cms-sw/cmssw/blob/791d9de9c05e0ffd341fc0e9510d7fcda3b1faf7/CalibPPS/AlignmentGlobal/plugins/PPSAlignmentWorker.cc#L277

and here:

https://github.com/cms-sw/cmssw/blob/791d9de9c05e0ffd341fc0e9510d7fcda3b1faf7/CalibPPS/AlignmentGlobal/plugins/PPSAlignmentWorker.cc#L288

but also the point here:

https://github.com/cms-sw/cmssw/blob/791d9de9c05e0ffd341fc0e9510d7fcda3b1faf7/CalibPPS/AlignmentGlobal/plugins/PPSAlignmentWorker.cc#L286

Tagging also the original author of the problematic code @MatiXOfficial

mmusich on Jul 29, 2022

Is it the comma that’s wrong?

Yes.

I dont see anything here, is it the whitespace? Dont we have a tonne of MEs with whitespace in them? (that work anyway)

I think the problem is that the path is checked (not only the histogram name) and when the file is remote, it includes also unacceptable characters in the lfn.

mmusich on Jul 28, 2022