cmssw: DQM bin-by-bin comparison missing after moving to ROOT 6.30

Looks like DQM bin by bin comparison plots are not available after moving to ROOT 6.30 on 13th Dec. ROOT was first integrated for CMSSW_14_0_X_2023-12-13-1100 IB and all PR tests using this or above IB have empty DQM plots e.g see

Log files for DQM comparison do not show any error ( https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2023-12-17-0000+79a965/60327/dqmBinByBinLog.log ) .

@cms-sw/dqm-l2 , could this is issue with DQM gui not able to process root 6.30 based plots?

About this issue

Original URL
State: open
Created 6 months ago
Comments: 46 (46 by maintainers)

Most upvoted comments

FYI, new DQM GUI with patched ROOT 6.14 has been deployed and DQM bin-by-bin comparisons look good e.g. see PR cms-sw/cmssw#43596 results and its DQM bin-by-bin comparison here

smuzaffar on Dec 19, 2023

@smuzaffar Thanks, it’s a different problem this time (same as #38980), we will try to fix it ASAP

nothingface0 on Mar 13, 2024

Or you can make use of output of one of existing unit test and upload it e.g. https://github.com/cms-sw/cmssw/blob/master/DQMServices/Demo/test/BuildFile.xml#L8 test do generate some root files so you can add another test e.g.

< test name="testDQMGUI" command="test-DQMGUI.sh">
  <flags PRE_TEST="TestDQMServicesDemo"/>
</test>

scram will run testDQMGUI after TestDQMServicesDemo

smuzaffar on Jan 18, 2024

Note that https://github.com/cms-sw/cmsdist/blob/comp_gcc630/root.spec is not using the tip of root 6.14 branch. So I would suggest to only apply https://github.com/root-project/root/commit/65ed49a726bd293edd259f2ceccbd7dc8756808f.patch on top of what is already used by comp_gcc630

smuzaffar on Dec 18, 2023

@nothingface0 , I can open a PR for cmsdist comp_630 branch to include this fix

@smuzaffar Already on it!

nothingface0 on Dec 18, 2023

The patch applies cleanly, works and has been pushed to the v6-14-00-patches branch.

pcanal on Dec 18, 2023

From the ROOT forum, it seems like the fix on the file reading ROOT side might be straightforward https://root-forum.cern.ch/t/error-in-tlist-clear-a-list-is-accessing-an-object-already-deleted-list-name-tlist-when-opening-a-file-created-by-root-6-30-using-root-6-14-09/57588/5

makortel on Dec 18, 2023

Let’s tag @pcanal here too.

No need, I already opened a thread on the ROOT forum 😃

nothingface0 on Dec 18, 2023

Let’s tag @pcanal here too.

makortel on Dec 18, 2023

Hello, this was already reported last week by another group as well (@cms-sw/pdmv-l2), and your suspicion seems to be correct, it’s due to the GUI using ROOT 6.14 which produces error messages when opening ROOT files created by 6.30:

Error in <TList::Clear>: A list is accessing an object (0x7f53bc738600) already deleted (list name = TList)

Since there are no plans to update the ROOT package supported by the comp team (here) to newer versions, we will proceed to ignore those messages for now, until we overhaul our DQMGUI deployment procedure.

We are in the process of deploying a fix any day now.

I will post here if we discover anything else.

(on behalf of DQM-DC)

nothingface0 on Dec 18, 2023

assign dqm

smuzaffar on Dec 18, 2023

type root

smuzaffar on Dec 18, 2023