scout: Problems using panel for searching for all cases for institute, when it exists with same name for other institute?
There appear to be some issues with searching with a panel when multiple ones with the same panel_name exist for different insitutes.
Users report not being able to see either, and as an admin I get both when on just one of the institutes.
Guessing we have some issues not checking both institute and panel_name plus version when selecting where we don’t have the actual panel _id. We could either fix that lookup, or as a workaround (which probably would be helpful to avoid versioning confusion) not allow users to assign already taken panel names.
About this issue
- Original URL
- State: open
- Created a year ago
- Reactions: 1
- Comments: 18 (10 by maintainers)
Yes, if something is missing there! I guess they can’t edit/suggest edits?
Ah, great! It took me a long time to realise the institutes that had the panels with the same display name, and similar panel names were collaborators, and because of https://github.com/Clinical-Genomics/scout/blob/5168094a4c7fc06669c7ab3c410f5469d3d477c7/scout/server/blueprints/institutes/controllers.py#L267 they are both shown. It would not hurt to block also having the same display name for panels, as content can be different, but as long as we understand it’s all fine. I think we can close it and leave it to the users if they want to risk having the same name for two collaborator institutes.
Hm, I can ask her: maybe she had help…
Mmm that’s weird, you are not even supposed to have 2 panels with the same name in the database…
Great, agreed! I have a few meetings anyway, so aiming for a release tomorrow sounds like a plan.
Perhaps we can include also a fix to this bug in the upcoming release? I can work on it today!