clappr: Incorrect buffer events with autoplay

When autoplay is true, there buffer start event is not called when it should. This also causes the spinning wheel to not appear on initial load.

The line that is responsible for “starting” the buffer event is this: https://github.com/clappr/clappr/blob/master/src/playbacks/html5_video/html5_video.js#L180 But if autoplay is true, instead of calling the .play function like normal playback, this line: https://github.com/clappr/clappr/blob/master/src/playbacks/hls/hls.js#L52 is calling _setupHls() directly, skipping the logic inside .play() basically, which screws the buffer start event firing

I suggest to just call this.play() instead of calling _setupHls() directly

Clappr Version: 0.2.57

About this issue

  • Original URL
  • State: closed
  • Created 8 years ago
  • Comments: 21 (20 by maintainers)

Commits related to this issue

Most upvoted comments

actually I forgot I think this was fixed here