openh264: Reintroduced Frame-Order bug in master/v2.2.0

Bug reported in https://github.com/cisco/openh264/issues/3305 has been reintroduced in master and https://github.com/cisco/openh264/tree/v2.2.0

Offending commit: dc17ceea7aae76131e30d72c69f801185e917b05

Easy way to test:

Compile FreeRDP from https://github.com/FreeRDP/FreeRDP/tree/master with cmake -GNinja -DWITH_OPENH264=ON
Connect to some windows RDP server with xfreerdp /v:someserver (AVC mode enabled)
Create a selection rectangle with a mouse left click
Release the rectangle
See that the rectangle is (in part) still visible

To verify the stream can be decoded properly:

Compile FreeRDP from https://github.com/FreeRDP/FreeRDP/tree/master with cmake -GNinja -DWITH_FFMPEG=ON
Retry above

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 31 (30 by maintainers)

Most upvoted comments

@akallabeth I have identified the issue. Somehow, POC (Picture Order Count) for every decoded picture is 0 and it does not increase (it is supposed to increase in a GOP). ReorderPicturesInDisplay can’t handle reordering correctly. I’ll try to fix it as soon as I can.

xiaotiansf on Feb 6, 2022