chef: ImmutableArrays and ImmutableHashes that have not had their cache populated are broken for internal ruby APIs

This is the other half of #6784

% cat ./apply.rb
#!/usr/bin/env chef-apply

node.default['foo']['baz'] = [ "one", "two" ]
puts node['foo']['baz']

% ./apply.rb
[ ... no output ... ]

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 21 (13 by maintainers)

Commits related to this issue

Workaround for Hash and Array merges Add `.to_h` workaround for https://github.com/chef/chef/issues/6792 Fixes https://github.com/chef-cookbooks/firewall/issues/185. — committed to sous-chefs/firewall by martinb3 6 years ago
feat: pin chef to 13.6.4 to avoid 13.7.x nasty bug ref: https://github.com/chef/chef/issues/6792 — committed to chef-platform/docker-centos-chef by deleted user 6 years ago
Upgrade to Chef 13.6.4 from 12.21.31 * Upgrades from chef 12.21.31 to 13.6.4, including dependent gems * Updates chefspec to 7.1.1 * Fixes usage of node.default.gitaly in gitaly recipe * Fixes loggin... — committed to gitlabhq/omnibus-gitlab by richardc 6 years ago

Most upvoted comments

So the actual line which was broken in the cookbook is this:

diff --git a/libraries/helpers_iptables.rb b/libraries/helpers_iptables.rb
index 5797d17..8a0b987 100644
--- a/libraries/helpers_iptables.rb
+++ b/libraries/helpers_iptables.rb
@@ -104,7 +104,7 @@ module FirewallCookbook
         # hash regardless of ipv6 status
         %w(iptables ip6tables).each do |name|
           input[name] = {} unless input[name]
-          input[name].merge!(default_ruleset(current_node))
+          input[name].merge!(default_ruleset(current_node).to_h)
         end
       end
     end

lamont-granquist on Jan 31, 2018

we reverted this, 13.7.x should be the only broken version(s).

lamont-granquist on May 25, 2018