Charts: Library name conflict with Apple Charts

ℹ Please fill out this template when filing an issue. All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you’ve filled in the info.

Per our *CONTRIBUTING guidelines, we use GitHub for bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag ios-charts.

Please remove this line and everything above it before submitting.

What did you do?

There’s apple Charts now. If we import Charts , when does the Xcode know it’s apple one or third party one?

What did you expect to happen?

ℹ Please replace this with what you expected to happen.

What happened instead?

ℹ Please replace this with of what happened instead.

Charts Environment

Charts version/Branch/Commit Number: Xcode version: Swift version: Platform(s) running Charts: macOS version running Xcode:

Demo Project

ℹ Please link to or upload a project we can download that reproduces the issue.

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 3
  • Comments: 43 (5 by maintainers)

Most upvoted comments

please update the package name, it’s 3 months after the discussion

@danielgindi would you like me to update my PR to include the podspec change or are you wanting to rename directories and source files as well?

Every PR should contain a very specific change. Otherwise it’s impossible to properly review.

I guess I’m waiting for a bit more participants here. If there are no other good ideas then we’ll rename to UICharts very soon and bump a major version.

I’m thinking UICharts

I doubt someone would use both at the same time. This seems to be implemented in swift 5.7 so maybe this could work https://github.com/apple/swift-evolution/blob/main/proposals/0339-module-aliasing-for-disambiguation.md

I disagree. We have a large app we support that has some “legacy” views using UIKit that have charts in them but we would also like to start adding Swift Charts to our SwiftUI views once iOS 16 rolls out. I imagine that use case could be common.

@danielgindi UICharts seems like a good name. Would also like to know when the renaming will happen!

Please don’t use UI as prefix, as it is already default prefix for UIKit classes

This is a major oversight on Apple’s side. Some of their engineers are probably aware that this library exists.

Seems like a bit of an ebullient and wishful statement. Are Apple expected to survey the entire third-party landscape and abstain from ever naming a framework similarly?

I’m thinking UICharts

In my opinion that is not a great name either. I use Charts on Mac (AppKit), for which it’s also designed—it’s a purposefully cross-platform framework. Besides that, “UI” is not particularly descriptive or unique. Better might be “GindiCharts”, or even “AndroidCharts” (in view of its lineage).

Do we know maybe when this rename can happen? (I am using lib via cocoapods)

We just need a good suggestion that will be acceptable for everyone and easy enough to migrate 😃 We will need to rename though, no running away from it.

Perhaps a name such as UIKitCharts (just off the top of my head) or something else to indicate that the implementation is in UIKit?

This is a major oversight on Apple’s side. Some of their engineers are probably aware that this library exists.

Now we need some ideas regarding the naming.

Also one question- does this happen also when not adding the Swift Charts framework to the project?

ok… this sucks, @jjatie @danielgindi @pmairoldi thoughts? What would be the appropriate name now?