changesets: The wrong dependents are generated in some rare cases with `linked` and changing to single file changesets

changeset add currently doesn’t care about the linked option and that creates a problem if a package is bumped at a higher level because of linked which means there should be some dependents.

A, B and C are all linked together and they are all currently at 1.0.0. B has a dependency on C.

A changeset is added:

A@major
C@patch

There will be no dependents generated. When bumping though, A and C will both be released as 2.0.0 and B won’t be released which is wrong since its dependency on C is out of range now.

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 16 (7 by maintainers)

Most upvoted comments

Strong agree on adding it before a major.

Do you wanna try implementing it?

I was going to say that maybe I should seperate out the create changeset package in the GitHub comment PR to another PR that can be merged but practically all of the logic is about calculating dependents so it’s probably better to start from the current state rather than that. I’ll seperate some TS conversion things from that into another PR though.