webamp: Missing opcode 255?
https://archive.org/cors/winampskin_BLAKK/BLAKK.wal has a file boombox2.maki which seems to contain an opcode 255 which we’ve never seen before. It’s possible that some other parsing error before that point is causing a bad reading.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 16 (10 by maintainers)
Commits related to this issue
- Add disabled regression test for https://github.com/captbaritone/webamp/issues/898 — committed to captbaritone/webamp by captbaritone 5 years ago
- Add disabled regression test for https://github.com/captbaritone/webamp/issues/898 — committed to captbaritone/webamp by captbaritone 5 years ago
I’ve added a failing test which you can enable to test here.
@jberg I think you were right to suspect the 255 number.
blockStartandblockEndhave opcodes above 255, but we only read a single byte when parsing opcodes.This is what the decompiler does, so we inherited the bug from that.