browserslist-ga: Samsung Internet data missing from JSON output

Hello,

I was looking into using this tool but the resulting browserslist-stats.json data is outputting 0 for all Samsung Internet (SI) versions:

"samsung": {
    "4": 0,
    "5": 0,
    "6.2": 0,
    "7.2": 0
  },

I’m using this tool to generate the JSON from a CSV rather than login directly. It pulls in the caniuse-parser.js. I can see the correct SI data in the CSV, just 0 in the output data. I believe this is because Samsung Internet isn’t being parsed in this file.

Thanks!

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 1
Comments: 19 (7 by maintainers)

Commits related to this issue

Add missing case for Samsung Internet (fixes #8) — committed to browserslist/browserslist-ga by dmfrancisco 5 years ago

Most upvoted comments

Thank you @dmfrancisco. It’s working when I use the npx github:browserslist/browserslist-ga command.

natewoodbridge on May 15, 2019

Looks good @dmfrancisco

rtymchyk on Apr 21, 2019

Oh oops, my bad, didn’t realize it was not released yet. I will test and get back to you.

rtymchyk on Apr 21, 2019

Thanks for confirming 👍 I’ll submit a PR this weekend with the changes

dmfrancisco on Feb 8, 2019

@dmfrancisco yep, all working now in caniuse.com - see Fyrd/caniuse#4742

jamespamplin on Feb 5, 2019

Thanks @dmfrancisco, raised the issue: Fyrd/caniuse#4742

jamespamplin on Jan 28, 2019

@dmfrancisco interesting, on caniuse.com when I import, Samsung is in the Browsers not included column. Couldn’t find the caniuse repo to raise/find the issue there.

jamespamplin on Jan 22, 2019