Surfingkeys: BUG: in normal mode, keystrokes are leaking to the site
I use Colemak keyboard layout so your j to scroll down is my e. For example, when scrolling down On Github, I often end up on the edit page (Github maps e to edit).
Steps to reproduce:
- In your Surfingkeys settings, map
etoj:map('e', 'j'); - Go to https://github.com/brookhong/Surfingkeys/blob/master/README.md
- Hold
eto scroll down
Expected: Page keep scrolling down
Actual: Page will scroll down but at some point you’ll find yourself here
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 18 (7 by maintainers)
Commits related to this issue
- Fixed #425 BUG: in normal mode, keystrokes are leaking to the site Mode.finish must be done synchronously in Mode.handleMapKey, otherwise it will fail to find Trie node for a repeat keydown event in ... — committed to linsong/Surfingkeys by brookhong 4 years ago
- Fixed #425 BUG: in normal mode, keystrokes are leaking to the site Mode.finish must be done synchronously in Mode.handleMapKey, otherwise it will fail to find Trie node for a repeat keydown event in ... — committed to amzyang/Surfingkeys by brookhong 4 years ago
Fixed in 0.9.60
The release for Firefox is published now, please have a try. The release for Chrome is pending review on Chrome Web Store.
Thanks @smhmd for the video, I have reproduced the issue on a virtual machine running ubuntu, will be fixed soon.
So everyone here with this issue are on Linux?
@Monirzadeh You can start from https://github.com/brookhong/Surfingkeys/blob/master/content_scripts/normal.js#L110