brave-browser: Warning message not being displayed, when click on `Confirm Sync code` without any code added
Description
Follow up of #2845
Warning message not being displayed, when click on Confirm Sync code without any code added.
steps to reproduce the issue is same as 2845
Actual result:
Expected result:
Warning message should be displayed as Invalid sync code. please try again
Reproduces how often:
Intermittent issue
Brave version (brave://version info)
| Brave | 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit) |
|---|---|
| Revision | ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796} |
| OS | Windows 10 |
Reproducible on current release:
- Does it reproduce on brave-browser dev/beta builds? no
Website problems only:
- Does the issue resolve itself when disabling Brave Shields? na
- Is the issue reproducible on the latest version of Chrome? na
Additional Information
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 38 (17 by maintainers)
@MRVDH this means the fix first will appear in dev, then in beta and then in release. Each step is a version bump and takes ~ 3 weeks https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule.
Just want to point out that this is not a problem with properly displaying a warning message. The sync code I enter is correct. The button just doesn’t do anything. See https://github.com/brave/brave-browser/issues/4756
Users are still facing the issue. Hence re-opening the issue and removing a Not actionable label
Verified passed with
Verification passed on
Verified test plan from https://github.com/brave/brave-browser/issues/3190#issuecomment-514802188
Verified error message displayed when no code or invalid code:
Verified entering a valid sync code added device to sync chain.
Verification passed on
@AlexeyBarabash after deliberating with the @brave/uplift-approvers team, we’re going to let this ride the trains from
NightlytoRelease. There’s a few +1’s from the community but I don’t think this is critical enough to warrant an uplift.0.68.xhas ~a week before release so we try to only uplift critical fixes 👍Here is a PR which should fix https://github.com/brave/brave-core/pull/3038 .
Also having the same issue with a valid sync code on a fresh (so latest) version of brave. Tried reloading with empty cache and hard reload with no difference. No errors in console.
EDIT: Managed to work around this by either bookmarking any web page or attempting to create your own sync chain, then cancelling. Not entirely sure which of these made it work, but it seems to have synced now.
If someone else could test this workaround, it may help fix this issue.
After messing around a bit it seems to work to do a hard reload (cmd+shift+R) on brave://sync page.