brave-browser: Subsequent delta updates on Windows fail 2/2

Description

On Windows, a delta update that gets applied after another delta update always fails and falls back to the full update.

Steps to Reproduce

  1. Install Brave 1.49.120 using its offline installer. Accept the UAC prompt to perform a system-wide installation.
  2. Close Brave and make sure you don’t have internet so Brave doesn’t accidentally get updated.
  3. Open a Windows command prompt with Administrator privileges (right-click->“Run as Administrator”).
  4. Download the delta installer to go from Brave 1.49.120 to 1.49.128.
  5. Enter the following in the command prompt: set BraveSoftwareUpdateIsMachine=1.
  6. Execute the delta installer in the same command prompt. For example by typing: C:\Users\micha\Downloads\brave_installer-delta-x64.exe. If you are testing Release, don’t append anything. If you are testing Nightly, append --chrome-sxs. If you are testing Beta, append --chrome-beta. For example: brave_installer-delta-x64.exe --chrome-beta.
  7. Repeat steps 4. - 6. for the delta installer to go from Brave 1.49.128 to 1.49.132
  8. Start Brave.

The above delta installer URLs are for the Release channel. For Beta, use and modify https://updates-cdn.bravesoftware.com/delta/Brave-Browser-Beta/x64-be/win/113.1.52.94/113.1.52.92/brave_installer-delta-x64.exe.

Actual result:

The version on brave://settings/help is 1.49.128.

Expected result:

The version on brave://settings/help should be 1.49.132.

Reproduces how often:

Always.

Steps to Reproduce more generally

Repeat the steps above for another first, second and third public versions of Brave. You can construct the delta URLs from the version numbers. Note: Deltas are only available for subsequent public versions. For example, there is also a 1.49.131 non-public/pre-release version. But because it isn’t public, there is no delta for it.

Related issues

The following issue also affects delta updates on Windows: #28989

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 26 (9 by maintainers)

Most upvoted comments

@LaurenWags Correct!

+4
mherrmann on Jun 12, 2023

@kjozwiak

@mherrmann we usually keep issues in the milestone were the PRs landed. Ideally, we would have two issues for the above scenario.

I see, that makes sense. I’ll remember it for the future.

Regarding 1.52.x, is there anything that needs to be checked?

The change in 17882 can affect Brave’s Windows installer and delta updates. I presume the Windows installer gets tested as part of all other tests. For deltas, it would be good to follow the test plan in PR #13563 for x64 Brave. (I see how multiple PRs for one issue make this a bit of a mess now, sorry.)

no worries! @mherrmann maybe it makes sense to open an issue via 1.52.x just to mention that the cases you mentioned should be checked on 1.52.x. This way QA can keep an eye out. If there’s any issues, we’ll know why as we’ll have an associated issue within 1.52.x. We can label it as verified near the end of the 1.52.x cycle if everything is looking good in terms of installers/delta updates.

+3
kjozwiak on May 18, 2023

Changing to release-notes/exclude as there additional fixes (https://github.com/brave/brave-browser/issues/30748) coming in subsequent version. Will include in release notes when all fixes are included.

@rebron @kjozwiak @mherrmann ok with this?

+2
LaurenWags on Jul 13, 2023

@mherrmann we’re still ok for 1.53.x without the fix to https://github.com/brave/brave-browser/issues/30748, correct? it seems that users still get updated, they just get the full installer?

cc @kjozwiak @rebron

+2
LaurenWags on Jun 12, 2023

Assuming https://github.com/brave/brave-browser/issues/30551 doesn’t block 1.52.x?

No, it doesn’t. Not in theory and also not in practice - I just checked from v1.52.109 and v1.52.102 and successfully received updates to v1.53.66.

+2
mherrmann on May 26, 2023

Yes, unfortunately there was the second regression mentioned in #30748 by @stephendonner; I’m sorry.

+1
mherrmann on Jun 9, 2023

@mherrmann can you review actual results section for Re- verified as following for 1.53.76 -->1.53.82-->1.53.83 case in https://github.com/brave/brave-browser/issues/29469#issuecomment-1577500329 please? Delta updates are failing (step 8) on second delta installer.

cc: @stephendonner

+1
MadhaviSeelam on Jun 8, 2023

Verification In progress using

Brave | 1.53.81 Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Pre-requisites:

  • Uninstall Brave from your system (all channels)
  • Run the following in an Administrator command prompt: “C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe” /uninstall
  • The following registry key should now not exist: HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\Clients.
  • Delete the following file if it exists: C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log.
  • Set the registry value HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\IsEnabledLogToFile to DWORD 1.

Upgrade 1.53.66 --> 1.53.76 Steps:

  1. Followed above Pre-requisite steps before installing Brave
  2. Installed BraveBrowserStandaloneBetaSetup.exe public beta installer for 1.53.66
  3. launched Brave
  4. Open brave://settings/help
  5. click Relaunch
  6. confirmed Brave updated to latest public beta version 1.53.76

Confirmed Delta updates received via brave_installer-delta-x64.exe for 1.53.66-->1.53.76`

[06/05/23 13:23:36.687][BraveUpdate:goopdate][15932:27616][Installing][display name: Brave Beta][app id: {103BD053-949B-43A8-9120-2E424887DE11}][installer path: C:\Program Files (x86)\BraveSoftware\Update\Install\{2FF268EE-DBD8-41A5-A307-2384995FE167}\brave_installer-delta-x64.exe][manifest args: --chrome-beta][installer data: ][untrusted data: ][priority: 10]
[06/05/23 13:23:36.687][BraveUpdate:goopdate][15932:27616][Running installer][C:\Program Files (x86)\BraveSoftware\Update\Install\{2FF268EE-DBD8-41A5-A307-2384995FE167}\brave_installer-delta-x64.exe][--chrome-beta][{103BD053-949B-43A8-9120-2E424887DE11}]
[06/05/23 13:23:55.943][BraveUpdate:goopdate][15932:27616][InstallerResult][{103BD053-949B-43A8-9120-2E424887DE11}][0]
[06/05/23 13:23:55.943][BraveUpdate:goopdate][15932:27616][InstallApp returned][0x0][{103BD053-949B-43A8-9120-2E424887DE11}][type:1][code: 30][][]
[06/05/23 13:23:55.953][BraveUpdate:goopdate][15932:27616][Started process][30708]
[06/05/23 13:23:55.962][BraveUpdate:goopdate][15932:27616][Started process][28944]
1.53.66 1.53.66 Installed logs Update 1.53.76 Delta logs
image image image image image

Upgrade 1.53.71 --> 1.53.74

Note: Confirmed Delta updates not received via brave_installer-delta-x64.exe for 1.53.71-->1.53.74`

1.53.66 1.53.66 Installed logs Update 1.53.76 Delta logs
image image image image image

Re- verified as following for 1.53.76 -->1.53.82–>1.53.83

  1. Install Brave 1.53.76 using its offline installer.
  2. Accepted the UAC prompt to perform a system-wide installation.
  3. Closed Brave and disconnected from internet so Brave doesn’t accidentally get updated.
  4. Open a Windows command prompt with Administrator privileges (right-click->“Run as Administrator”).
  5. Download the delta installer to go from Brave 1.53.76 to 1.53.82.
  6. Enter the following in the command prompt: set BraveSoftwareUpdateIsMachine=1.
  7. Execute the delta installer in the same command prompt. For example by typing: C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta.
  8. Repeat steps 5 - 7 for the delta installer to go from Brave 1.53.82 to 1.53.83
  9. Start Brave.

Actual Results:

  • Got Deltas for the first update 1.52.76–>1.52.82
  • However also see unspecified installation failure error.
  • Looks like 1.53.83 is failed to install as I didn’t see UAC when I executed delta installer for 1.53.82->1.53.83
  • tried updating via brave://settings/help. Got the Update error
  • Refresh the page and got full update.
[06/07/23 14:54:47.793][BraveUpdate:goopdate][31768:13864][Installing][display name: Brave Beta][app id: {103BD053-949B-43A8-9120-2E424887DE11}][installer path: C:\Program Files (x86)\BraveSoftware\Update\Install\{6951E7F1-EF83-4EA7-87DF-DB8E739D54E7}\brave_installer-delta-x64.exe][manifest args: --chrome-beta][installer data: ][untrusted data: ][priority: 0]
[06/07/23 14:54:47.793][BraveUpdate:goopdate][31768:13864][Running installer][C:\Program Files (x86)\BraveSoftware\Update\Install\{6951E7F1-EF83-4EA7-87DF-DB8E739D54E7}\brave_installer-delta-x64.exe][--chrome-beta][{103BD053-949B-43A8-9120-2E424887DE11}]
[06/07/23 14:54:58.629][BraveUpdate:goopdate][31768:13864][InstallerResult][{103BD053-949B-43A8-9120-2E424887DE11}][1]
[06/07/23 14:54:58.629][BraveUpdate:goopdate][31768:13864][Installer failed][C:\Program Files (x86)\BraveSoftware\Update\Install\{6951E7F1-EF83-4EA7-87DF-DB8E739D54E7}\brave_installer-delta-x64.exe][--chrome-beta][8]
[06/07/23 14:54:58.629][BraveUpdate:goopdate][31768:13864][InstallApp returned][0x80040902][{103BD053-949B-43A8-9120-2E424887DE11}][type:4][code: 8][Installation failed due to unspecified error. Please download Brave again.][]
ex ex ex ex ex
imageimage image image image image
+1
MadhaviSeelam on Jun 7, 2023

@kjozwiak I’ve created https://github.com/brave/brave-browser/issues/30485 now to capture this 😃

+1
mherrmann on May 22, 2023

Removing QA Pass-macOS as milestone for this issue was adjusted.

+1
LaurenWags on May 17, 2023

I believe the milestone for this should be 1.53.x and have changed it from 1.52.x. There were two PRs that fix this issue: 17882 is in 1.52.x while 18043 is in 1.53.x. I believe this can only be fully tested with 1.53.x. What do you think @stephendonner @MadhaviSeelam?

@mherrmann we usually keep issues in the milestone were the PRs landed. Ideally, we would have two issues for the above scenario. One via 1.52.x & 1.53.x. The one in 1.52.x would be labelled as QA/No as the above can only be verified via 1.53.x. Then another issue within 1.53.x labelled as QA/Yes. The rule that we usually follow is one PR per issue so you don’t run into cases where one PR spans ~2-3 milestones and there’s only one issue.

For now, leaving this in 1.53.x works 👍 Regarding 1.52.x, is there anything that needs to be checked? Just double checking that we’re not going to ship with partial fixes/code that might cause problems.

+1
kjozwiak on May 17, 2023

Makes perfect sense to me, @mherrmann 👍

+1
stephendonner on May 17, 2023

I believe the milestone for this should be 1.53.x and have changed it from 1.52.x. There were two PRs that fix this issue: 17882 is in 1.52.x while 18043 is in 1.53.x. I believe this can only be fully tested with 1.53.x. What do you think @stephendonner @MadhaviSeelam?

+1
mherrmann on May 17, 2023

Added OS/macOS label as per the testplan , Widevine functionality needs to be tested on macOS.

Specifically:

We need to make sure that DRM-protected content can still be played at the highest quality. It should be possible to test this with Netflix or Amazon Prime, verifying that the video quality offered by the site is as high as before this PR.

more info: https://bravesoftware.slack.com/archives/C012NN4F6UU/p1683648954812479

+1
MadhaviSeelam on May 12, 2023

Thank you @stephendonner, yes, I meant https://github.com/brave/brave-core/pull/17882.

+1
mherrmann on Apr 12, 2023
Read more comments on GitHub
← brave-browser: Subsequent delta updates on Windows fail
brave-browser: Test failure: BraveNetworkAuditTest.BasicTests →