brave-browser: sometimes geolocation no longer working (uses old endpoints)
Description
Starting with 1.14.x geolocation no longer works on macOS Mojave. It seems on 1.13.x and prior we were proxying thru location.brave.com, however with 1.14.x that proxy doesn’t seem to be there so geolocation fails.
Note, this is working for @kjozwiak using Catalina. Additionally, @btlechowski checked Linux and Windows and geolocation is working there as well.
Steps to Reproduce
- Install any of the following: 1.14.81, 1.14.84 (current release), 1.15.x, 1.16.x.
- Navigate to https://browserleaks.com/geo and/or https://html5demos.com/geo/.
- Allow location from prompt.
Actual result:
Location service fails:
Expected result:
Should work as it did in 1.13.86:

Reproduces how often:
easy
Brave version (brave://version info)
Brave 1.14.81 Chromium: 85.0.4183.102 (Official Build) (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS macOS Version 10.14.6 (Build 18G3020)
Brave 1.14.84 Chromium: 85.0.4183.121 (Official Build) (64-bit)
Revision a81aa729a8e1fd413943a339393c82e7b8055ddc-refs/branch-heads/4183@{#1864}
OS macOS Version 10.14.6 (Build 18G3020)
Brave | 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.14.6 (Build 18G3020)
Version/Channel Information:
- Can you reproduce this issue with the current release? yes, 1.14.x
- Can you reproduce this issue with the beta channel? yes, 1.15.x
- Can you reproduce this issue with the nightly channel? yes, 1.16.x
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
- Does the issue resolve itself when disabling Brave Rewards?
- Is the issue reproducible on the latest version of Chrome? no, used version 85.0.4183.121 (Official Build) (64-bit)
Miscellaneous Information:
cc @rebron
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 18 (14 by maintainers)
This has been isolated to one of the release build nodes which had an old
~/.npmrcfile overriding the one created in the workspace during the build process. Issue should be fixed with next builds for each channel.@kjozwiak a little late but checked this on M1 and confirmed we’re using
location.brave.comwhen requesting for geolocation permissions.@iefremov I’ve just fixed that issues and it only affected PR builds.
@kjozwiak I guess the problem is not specific to geolocation, rather it is something general that affects CI. I.e. it easily can hit any other feature 😄
posting a link to slack discussion just for context and cc @mihaiplesa https://bravesoftware.slack.com/archives/C7VLGSR55/p1605716007144900?thread_ts=1605674399.117500&cid=C7VLGSR55
Removing
OS/macOStill we know 100% this only affectsmacOS.