brave-browser: Incorrect error message for expired TLS certs

Description

Sites with an expired TLS cert show a “your clock is ahead”.

Also reported on https://community.brave.com/t/expired-server-certificate-handled-as-client-clock-error/253930.

Steps to Reproduce

  1. Visit https://expired.badssl.com/

Actual result:

Screenshot from 2021-05-28 19-25-07

Expected result:

Screenshot from 2021-05-28 19-25-37

Reproduces how often:

Always

Desktop Brave version:

Brave | 1.26.43 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Linux

Android Device details:

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 3a
  • Android version: 11

Version/Channel Information:

  • Can you reproduce this issue with the current release? YES
  • Can you reproduce this issue with the beta channel? YES
  • Can you reproduce this issue with the nightly channel? YES

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? NO

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Reactions: 10
  • Comments: 30 (9 by maintainers)

Most upvoted comments

Should be fixed now.

The problem is caused by some discrepancies in how “precise” network time is determined in the browser. We are figuring out a fix

thanks for the reports, we are looking into this.

Issue still present for expired TLS certs

Reproduced via https://expired.badssl.com/ on Version 1.26.74 Chromium: 91.0.4472.124 (Official Build) (64-bit) (Windows 10)

Brave-vs-Chrome-Bug-Expired-Certs

  • Clock time is valid & synced
  • Issue not present on Chrome Version 91.0.4472.124 (Official Build) (64-bit) (Windows 10)

Extra Point: I think that such a situation where there is absolutely no way to bypass an error should be avoided. There should be some way to bypass such errors, even if it takes multiple (advanced) steps to do so (eg. flag to enable & typing thisisabadidea). Such situations are rendering the browser unusable and forcing the user to switch browsers

Should be fixed now.

It works for me in the latest official release, great news! Thank you! (Version: 1.27.108 Chromium: 92.0.4515.107)

Is it possible to include a hotfix to allow a user to proceed through the advanced menu like other certificate issues?

Still an issue on: Version 1.26.77 Chromium: 91.0.4472.164 (Official Build) (64-bit)

Issue still present in current beta in my latest tests:

Build Version Status
Official 1.26.74 Chromium: 91.0.4472.124 (Official Build) (64-bit) (Windows 7) Clock error
Beta 1.27.102 Chromium: 91.0.4472.124 (Official Build) beta (64-bit) (Windows 7) Clock error
Nightly 1.28.77 Chromium: 92.0.4515.93 (Official Build) nightly (64-bit) (Windows 7) Clock error

2021-07-14_10-49-21

Still present, Version 1.26.74 Chromium: 91.0.4472.124 (Official Build) (x86_64) on macOS 11.3.

The issue is still present on the Brave version 1.26.67, with Chromium: 91.0.4472.114

Same here June 2021: can’t get to my own website because “the clock is wrong” but it is correct. Any workaround?

Same issue with multiple sites .