brave-browser: Edit person setting is missing

Description

Edit person setting is missing. Found while verifying #4333

Steps to Reproduce

  1. Install beta/dev/nightly profile
  2. Person settings is missing
  3. Can’t edit the the profile to add some cool new profile icons

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux
Brave 0.66.76 Chromium: 75.0.3770.38 (Official Build) dev(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux
Brave 0.67.62 Chromium: 75.0.3770.38 (Official Build)nightly (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? No Chrome still has the option under Chrome name and picture on Chrome release and Beta as well

Miscellaneous Information:

cc: @bsclifton @petemill @rebron @brave/legacy_qa

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Reactions: 28
  • Comments: 20 (4 by maintainers)

Most upvoted comments

Yep just waiting for a review at https://github.com/brave/brave-core/pull/3140 😃

I get the issue on the current browser ! OP said “Can you reproduce this issue with the current release? No”. Well, I definitely can 😉 Or maybe the download link from the brave website actually got me a dev version ? I’ve got : Brave | 0.65.121 Chromium: 75.0.3770.100 (Build officiel) (64 bits) Capture d’écran 2019-06-29 à 23 41 32

+1 Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)

I get the issue on the current browser ! OP said “Can you reproduce this issue with the current release? No”.

This is probably because when OP created the issue, this feature had been working in 0.64.x (at least in some way; iirc, I was able to edit the default user and change the name/image back then), which was the current release at that time.