brave-browser: Downloads bubble doesn't popup when the download is blocked/dangerous (safe browsing disabled)

Description

@simonhong there is an tiny little bug with the Downloads bubble, where if you disable Safe browsing and a ‘dangerous’ downloaded is blocked, the bubble doesn’t popup, and the only way to download the file is by going to downloads page (ctrl+j) and click keep and then keep it anyway.

The easiest way to reproduce this is by creating a new profile, but I noticed it is also affecting my normal profile where I have never had Safe Browsing enabled.

The bug seems to get resolved in normal windows if you click keep and then keep anyway, in my test, new downloads are working as expected after doing that, even on restart. Also, it worked fine when I had Safe Browsing on and downloaded a file, and then disabled it.

I guess the problem seems to be bigger for InPrivate windows though, because I noticed that if you download a file and ‘fix’ the issue by keeping the file, once you close the window and open a new InPrivate window and try to download a ‘dangerous’ file again, the bubble will not popup until you keep it and keep it anyway again.

Steps to Reproduce

  1. Create new profile/User Data.
  2. go to brave://settings/security and disable Safe Browsing.
  3. Go to https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  4. Nothing seems to happen
  5. Go to downloads page, and the download should only appear there to discard it or keep it
  6. (optional) Discard it and go back to the page and try to download the file again to confirm it still doesn’t work.
  7. Click keep and then keep anyway
  8. Future downloads should show the bubble as expected (until it doesn’t)

Actual result:

brave_2023-04-12_04-19-29

Brave version (brave://version info)

1.52.36 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit) - Windows 11 Pro 21H2 22000.1696

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 15 (6 by maintainers)

Commits related to this issue

Most upvoted comments

@simonhong @rebron can you/the team take a look at #30626 when you get a chance? I keep running into it on both nightly and beta, when trying to test this issue and around the area, too. Thanks!

I’ll take a look