cordova-ionic-phonegap-branch-deep-linking-attribution: Hook is not working
I do not know why, but the Branch Cordova Plugin will not be added to the app (I am using Cordova 8.1.2 / Cordova-Android 7.1.4). After removing the following hook from plugin.xml it works:
<hook src="src/scripts/hooks/beforePluginInstall.js" type="before_plugin_install" />
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 4
- Comments: 23 (7 by maintainers)
We hope release 3.1.5 solved this issue for everyone
hello all, we tested a change with 3.1.4 that did not appear to resolve the issue. We modified the plugin hooks and released a beta candidate,
3.1.5-beta.0to unblock most folks. Can anyone that tests it out please let us know whether it resolves this issue? Separately, we are testing #533 to use Cocoapods directly.3.0.0should be the most stable version. We are working on this actively.I can confirm that innomobile-branch-cordova-sdk@3.1.7 worked. Thanks, @paulstelzer.
But I also want to highlight a dependency issue that held us “hostage” wherein we cannot create a build because of this issue even if we used old versions that were supposedly working before. Removing branch plugin also meant changing our code to remove the related features. Felt like a helpless situation that nobody should be experiencing. Hope this issue can help improve the branch plugin
@aaaronlopez, confirming that
3.1.5-beta.0is working for both Android and iOS buildsI wrote a PR (#533) that removes the cocoapods dependency (something that is directly integrated in cordova ios) and removed the hook, so it’s working. You can test it by install https://www.npmjs.com/package/innomobile-branch-cordova-sdk (just replace
branch-cordova-sdkwithinnomobile-branch-cordova-sdkin your config.xml if you want to test it - or wait until the Branch team insert a fix or merge my PR)