bitshares-ui: MyMarkets does not use replaceName for assets
In MyMarkets overview
symbols are directly printed (for base and quote), without using utils.replaceName or AssetName component, see
https://github.com/bitshares/bitshares-ui/blob/1ee0ba3264abb63a3c06353e35731e80c7aee56d/app/components/Exchange/MyMarkets.jsx#L1048
About this issue
- Original URL
- State: open
- Created 6 years ago
- Comments: 24 (24 by maintainers)
@happyconcepts See #1613
Found a new issue with the implicit approach by looking into ETH.
There is actually an asset called ETH, which is neither a bitAsset or from a trusted gateway. It is even highlighted in the current reference UI by showing up in MyMarkets https://wallet.bitshares.org/#/market/OPEN.DOGE_ETH
Having said that, the logic should be even more refined that you can either
Examples for:
My vote would be for 1. since I don’t see any other way that a non-prefixed asset should be trusted, other than being a bitAsset. I find the issue with ETH quite crucial actually.
I think it’s very important to group markets this way in order to provide access to all liquid markets, and it also makes it easier for users to actually find the best, most liquid markets.