biome-zed: Formatting doesn't seem to work in `Zed 0.151.2`

#45 Fixes the issue of biome not being downloaded at all but still the downloaded version isn’t used to do formatting when formatting is enabled. Obviously, the fixes related to it also don’t get applied though I don’t if that might be a separate problem or just a resultant of this one.

Steps to Reproduce

  1. Install biome from the extensions tab
  2. Open a file with an error.
  3. Ask biome to format by changing your configuration.
  4. Observe that no formatting happens

Config

//biome
{
  "lsp": {
    "biome": {
      "settings": {
        "config_path": "~/Code/biome.json",
        "require_config_file": false
      }
    }
  },
  "formatter": {
    "language_server": {
      "name": "biome"
    }
  },
  "code_actions_on_format": {
    "source.fixAll.biome": true,
    "source.organizeImports.biome": true
  }
}


About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 16 (3 by maintainers)

Commits related to this issue

Most upvoted comments

Code actions seem to be fixed now after latest Biome release. I was able to organize imports and apply safe fixes on save.

biome 1.9.2
biome-zed 0.1.2
zed 0.153.6
// settings.json
{
  "formatter": {
    "language_server": {
      "name": "biome"
    }
  },
  "code_actions_on_format": {
    "source.fixAll.biome": true,
    "source.organizeImports.biome": true
  }
}

Formatting is working for me, but code actions aren’t running. On Zed 154.

Same issue here. Biome is working and is detecting errors - but it’s not running formatting. And when manually running format, it’s not running the code actions.

Screenshot 2024-09-12 at 1 20 07 PM Screenshot 2024-09-12 at 1 20 15 PM Screenshot 2024-09-12 at 1 21 55 PM