biome: πŸ› EditorConfig parsing fails if .editorconfig contains `[...]`

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v22.13.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/9.9.0"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  Γ— Failed to parse the .editorconfig file.

    Caused by:
      Custom("INI syntax error: section name contains ']'")

.editorconfig:

root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 4
indent_style = space
insert_final_newline = true

[*.{{ht,ya,to}ml,{[mc],}[jt]s{,x},{s,}css,json}]
indent_size = 2

https://github.com/tats-u/biome-editorconfig

https://editorconfig.org/ says:

Syntax Description
[name] Matches any single character in name
[!name] Matches any single character not in name

EditorConfig files use an INI format that is compatible with the format used by Python ConfigParser Library, but [ and ] are allowed in the section names.

This means this .editorconfig is valid and Biome must parse it.

Expected result

No errors

Code of Conduct

  • I agree to follow Biome’s Code of Conduct

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 1
  • Comments: 16 (8 by maintainers)

Most upvoted comments

I more and more wonder if it was a good idea of enabling EditorConfig support by default.

I wonder that too. We’re still on time πŸ˜ƒ

I more and more wonder if it was a good idea of enabling EditorConfig support by default.