betfair: stream.stop() breaks when async=True

When calling stream.stop() when async=True, I get the following error:

Traceback (most recent call last): File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner self.run() File "/usr/lib/python2.7/threading.py", line 754, in run self.__target(*self.__args, **self.__kwargs) File "/usr/local/lib/python2.7/dist-packages/betfairlightweight/streaming/betfairstream.py", line 191, in _read_loop received_data_raw = self._receive_all() File "/usr/local/lib/python2.7/dist-packages/betfairlightweight/streaming/betfairstream.py", line 223, in _receive_all raise SocketError('Connection closed by server') SocketError: Connection closed by server

This is because the threads calling stream._read_loop don’t have time to see that stream._running has been set to False, thus are still trying to read from the socket, even though the socket has been closed by the stream.stop().

A dirty solution to this is to do: stream._running = False time.sleep(5) # this gives time for _read_loop threads to see they need to stop reading from the socket. stream.stop() However, I think I nicer solution would to stop the threads directly in the stream.stop() function before the socket is closed. I can add this fix and test locally. Would you want me to merge this into master?

Cheers, Jack