puppeteer-extra: [Bug] Electron process becomes unresponsive to SIGINT

Describe the bug

Sending a SIGINT signal to the Electron process does not kill the process.

Code Snippet

package.json

{
  "name": "test",
  "main": "main.js",
  "scripts": {
    "postinstall": "electron-builder install-app-deps",
    "start": "electron ."
  },
  "dependencies": {
    "puppeteer": "^8.0.0",
    "puppeteer-extra": "^3.1.16",
    "puppeteer-extra-plugin-stealth": "^2.7.6"
  },
  "devDependencies": {
    "electron": "^12.0.2",
    "electron-builder": "^22.10.5"
  }
}

main.js

const puppeteer = require('puppeteer-extra')
const StealthPlugin = require('puppeteer-extra-plugin-stealth')
puppeteer.use(StealthPlugin())
puppeteer.launch().then(browser => browser.close());

Versions

  System:
    OS: Linux 5.8 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 227.82 MB / 15.36 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 12.20.1 - ~/.nvm/versions/node/v12.20.1/bin/node
    npm: 7.6.3 - ~/.nvm/versions/node/v12.20.1/bin/npm
  npmPackages:
    puppeteer: ^8.0.0 => 8.0.0 
    puppeteer-extra: ^3.1.18 => 3.1.18 
    puppeteer-extra-plugin-stealth: ^2.7.6 => 2.7.6

About this issue

Original URL
State: closed
Created 3 years ago
Reactions: 1
Comments: 15 (8 by maintainers)

Commits related to this issue

Make sure shutdown signals aren't trapped forever Right now, it seems like this library is preventing the `SIGINT` (ctrl-C) signal from shutting down my project. I made these changes using github'... — committed to Tyler-Murphy/signalwire-node by Tyler-Murphy 3 years ago

Most upvoted comments

maybe we are on same problem try check on me, I thing it better than change “process” event

but maybe other still use puppeteer lower than version 1.6.0 ? Replace onClose to onDisconnected (Version 1.6.0+)

https://github.com/berstend/puppeteer-extra/pull/530 or maybe need still support lower version ?

dev-hyperweb on Jul 22, 2021

Does the problem go away if the user-agent-override evasion is deleted from the enabled stealth plugins?

// Remove specific evasion from enabled ones dynamically
const pluginStealth = require('puppeteer-extra-plugin-stealth')()
pluginStealth.enabledEvasions.delete('user-agent-override')
puppeteer.use(pluginStealth)

berstend on Mar 31, 2021