bazel: Bazel 6.0.0rc4 breaks Bazel RBE tests
This was first detected in the downstream test for Bazel 6.0.0rc4: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2761#0184d3b5-3cf0-410a-984d-2fdfdf78a49b
And verified in https://buildkite.com/bazel/bazel-bazel/builds/21471#0184e876-6406-4909-9a81-e8dc957b471f
Integration tests with test args are failing remotely with test logs look like:
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //src/test/shell/bazel:bazel_example_test
-----------------------------------------------------------------------------
WARNING: Passing test names in arguments (--test_arg) is deprecated, please use --test_filter='/usr/lib/jvm/java-11-openjdk-amd64' instead.
WARNING: Arguments do not specify tests!
INFO[bazel_example_test 2022-12-06 17:28:07 (+0000)] bazel binary is at /b/f/w/bazel-out/k8-fastbuild/bin/src/test/shell/bazel/bazel_example_test.runfiles/io_bazel/src/test/shell/bin
INFO[bazel_example_test 2022-12-06 17:28:07 (+0000)] setting up client in /b/f/w/_tmp/55e5a95f98bdfb926d4a13d2054933c5/workspace
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 19 (11 by maintainers)
Commits related to this issue
- Throw a different Exception when failing to download Bazel at a given commit Related https://github.com/bazelbuild/bazel/issues/16933#issuecomment-1339738792 - The "Publish Bazel binaries" pipeline ... — committed to bazelbuild/continuous-integration by meteorcloudy 2 years ago
- Fix Bash `runfiles_current_repository` with RBE During remote execution, absolute paths may not contain `execroot` segments. Work towards #16933 Closes #16946. PiperOrigin-RevId: 493876135 Change-... — committed to bazelbuild/bazel by fmeum 2 years ago
- Fix Bash `runfiles_current_repository` with RBE During remote execution, absolute paths may not contain `execroot` segments. Work towards #16933 Closes #16946. PiperOrigin-RevId: 493876135 Change-... — committed to bazelbuild/bazel by fmeum 2 years ago
- Fix corner cases in Bash runfiles library Due to tests not actually verifying the exit code of rlocation calls, a few special cases were not handled correctly. In particular, absolute paths still wen... — committed to fmeum/bazel by fmeum 2 years ago
- Fix corner cases in Bash runfiles library Due to tests not actually verifying the exit code of rlocation calls, a few special cases were not handled correctly. In particular, absolute paths still wen... — committed to fmeum/bazel by fmeum 2 years ago
- Fix Bash `runfiles_current_repository` with RBE (#16963) During remote execution, absolute paths may not contain `execroot` segments. Work towards #16933 Closes #16946. PiperOrigin-RevId: 49... — committed to bazelbuild/bazel by Wyverald 2 years ago
- Throw a different Exception when failing to download Bazel at a given commit (#1507) Related https://github.com/bazelbuild/bazel/issues/16933#issuecomment-1339738792 BuildKiteException is always ... — committed to bazelbuild/continuous-integration by meteorcloudy 2 years ago
- Fix corner cases in Bash runfiles library Due to tests not actually verifying the exit code of rlocation calls, a few special cases were not handled correctly. In particular, absolute paths still wen... — committed to fmeum/bazel by fmeum 2 years ago
- Fix corner cases in Bash runfiles library (#16988) Due to tests not actually verifying the exit code of rlocation calls, a few special cases were not handled correctly. In particular, absolute paths ... — committed to bazelbuild/bazel by fmeum 2 years ago
- Fix corner cases in Bash runfiles library Due to tests not actually verifying the exit code of rlocation calls, a few special cases were not handled correctly. In particular, absolute paths still wen... — committed to iancha1992/bazel by fmeum 2 years ago
- Fix corner cases in Bash runfiles library Due to tests not actually verifying the exit code of rlocation calls, a few special cases were not handled correctly. In particular, absolute paths still wen... — committed to iancha1992/bazel by fmeum 2 years ago
- Throw a different Exception when failing to download Bazel at a given commit (#1507) Related https://github.com/bazelbuild/bazel/issues/16933#issuecomment-1339738792 BuildKiteException is always ... — committed to fmeum/continuous-integration by meteorcloudy 2 years ago
@coeuvre Thanks, I will remove that assumption in a second PR.
@meteorcloudy The Bash runfiles test didn’t cover the exit codes of
rlocation
, only whatever it printed, and thus missed some corner cases. I have reworked the tests to check the exit codes and am now fixing these cases.