bazel: 0.25 gratuitously breaks cc_common.compile/link
Description of the problem / feature request:
Commit 976876d21de9f502bd64156b1acd9967028d2e95 changed the API for cc_common.compile
and cc_common.link
in a backwards incompatible way (fine), but also entirely removed the implementation. This would be sort of fine had that deleted implementation not persisted into a release version, but it has done so.
This has broken a number of Kythe tests with no recourse but to blacklist 0.25.
Feature requests: what underlying problem are you trying to solve with this feature?
Not gratuitously breaking users of older in-the-progress-of-changing APIs with no recourse but to blacklist that release.
Bugs: what’s the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Take a previously working use of the old API (say https://github.com/kythe/kythe/blob/8cd2434b921b32bc2f941431c563cfabc6b384f9/tools/build_rules/verifier_test/cc_indexer_test.bzl#L152) and update it to the new API. Watch as the rule fails with:
method invocation returned None, please file a bug report: compile(actions for<aspect context for /..., <13 more arguments>)
What operating system are you running Bazel on?
Debian GNU/Linux rodete
What’s the output of bazel info release
?
release 0.25.0
Have you found anything relevant by searching the web?
Yes, I found the commit which broke things.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 1
- Comments: 18 (9 by maintainers)
Commits related to this issue
- Add implementation to removed methods to address https://github.com/bazelbuild/bazel/issues/8226 — committed to bazelbuild/bazel by dkelmer 5 years ago
- Add implementation to removed methods to address https://github.com/bazelbuild/bazel/issues/8226 — committed to bazelbuild/bazel by dkelmer 5 years ago
- Release 0.25.1 (2019-05-07) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to bazelbuild/bazel by a-googler 5 years ago
- Release 0.25.1 (2019-05-07) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to bazelbuild/bazel by a-googler 5 years ago
- Release 0.25.2 (2019-05-10) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to bazelbuild/bazel by a-googler 5 years ago
- Release 0.25.2 (2019-05-10) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to bung-wg2/bazel by a-googler 5 years ago
- Release 0.25.3 (2019-05-23) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to bazelbuild/bazel by a-googler 5 years ago
- Release 0.25.2 (2019-05-10) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to irengrig/bazel by a-googler 5 years ago
- Release 0.25.3 (2019-05-23) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to irengrig/bazel by a-googler 5 years ago
- Release 0.25.3 (2019-05-23) Baseline: 03662462941953dad23af88693804b8b1d4430b9 Cherry picks: + 3f7f255f9a8345b8898e3953e7e53d68106cc63d: Windows: fix native test wrapper's arg. escaping ... — committed to irengrig/bazel by a-googler 5 years ago
hey @shahms, we’re working on creating a patch release to fix this issue, hang tight 😃
(For the record, the changes in your reply had all ready been attempted prior to filing the bug, hence the “method invocation returned None” in the original bug description)